Fix NRE calling virtual Object methods on value types via inline SRTP#19511
Merged
Fix NRE calling virtual Object methods on value types via inline SRTP#19511
Conversation
… SRTP (#8098) When an inline SRTP function calls a virtual Object method (ToString, GetHashCode, Equals) on a value type, the compiler emits a constrained callvirt instruction. ECMA-335 requires the receiver of a constrained call to be a managed pointer (&), but the codegen was pushing the raw value (or reference) directly onto the stack. Root cause: MakeMethInfoCall (used by SRTP trait resolution) computes PossibleConstrainedCall but never takes the receiver's address — unlike TakeObjAddrForMethodCall which handles this correctly in the type-checker path for direct calls. Fix: In MakeMethInfoCall, when ComputeConstrainedCallInfo returns Some (indicating a constrained call is needed), take the address of the receiver via mkExprAddrOfExpr before building the IL call expression. This mirrors TakeObjAddrForMethodCall and ensures the expression tree contains the proper address-of wrapper, so GenILCall receives a managed pointer on the stack as ECMA-335 requires. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
T-Gro
force-pushed
the
bugfix/nullreference-virtual-object
branch
from
b957b25 to
4800b45
Compare
Contributor
❗ Release notes required
|
abonie
approved these changes
Apr 15, 2026
github-project-automation
bot
moved this from New
to In Progress
in F# Compiler and Tooling
github-project-automation
bot
moved this from In Progress
to Done
in F# Compiler and Tooling
Copilot AI
pushed a commit
that referenced
this pull request
Apr 15, 2026
… SRTP (#8098) (#19511) When an inline SRTP function calls a virtual Object method (ToString, GetHashCode, Equals) on a value type, the compiler emits a constrained callvirt instruction. ECMA-335 requires the receiver of a constrained call to be a managed pointer (&), but the codegen was pushing the raw value (or reference) directly onto the stack. Root cause: MakeMethInfoCall (used by SRTP trait resolution) computes PossibleConstrainedCall but never takes the receiver's address — unlike TakeObjAddrForMethodCall which handles this correctly in the type-checker path for direct calls. Fix: In MakeMethInfoCall, when ComputeConstrainedCallInfo returns Some (indicating a constrained call is needed), take the address of the receiver via mkExprAddrOfExpr before building the IL call expression. This mirrors TakeObjAddrForMethodCall and ensures the expression tree contains the proper address-of wrapper, so GenILCall receives a managed pointer on the stack as ECMA-335 requires. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: T-Gro <46543583+T-Gro@users.noreply.github.com>
This was referenced Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8098
Widens the address-taking condition in
GenWitnessExprto also trigger whenComputeConstrainedCallInforequires a constrained call, not just whenminfo.IsStruct.