Preserve enum type in custom attribute argument of type obj (#995)#19975
Open
edgarfgp wants to merge 9 commits into
Open
Preserve enum type in custom attribute argument of type obj (#995)#19975edgarfgp wants to merge 9 commits into
edgarfgp wants to merge 9 commits into
Conversation
Contributor
❗ Release notes requiredYou can open this PR in browser to add release notes: open in github.dev
|
9649085 to
013cb43
Compare
Contributor
|
🔍 Tooling Safety Check — Affects-Compiler-Output
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Assigning an enum to a custom attribute argument of type
objloses the enum type. The value is stored in metadata as the underlyingint32, so reading the attribute back gives a plainintrather than the enum. C# stores the same thing as the enum, so this is also a cross-language inconsistency.Fixes #995.
Before
After
The enum type is now written into the attribute blob using the ECMA-335 enum tag (
0x55+ type name), the same encoding C# produces, so it round-trips as the enum. Reading that encoding back (which previously threw) is also handled, and decode/encode are kept symmetric so static linking preserves it.Quotations
The original triage worried this needed quotation/TAST changes. It doesn't: the fix only reads the enum type (already on the
Constnode) when emitting the attribute. Quotations are untouched and already keep the enum type — added a test to confirm.