Fix packaging of design-time providers referenced via ProjectReference#19979
Open
T-Gro wants to merge 1 commit into
Open
Fix packaging of design-time providers referenced via ProjectReference#19979T-Gro wants to merge 1 commit into
T-Gro wants to merge 1 commit into
Conversation
Contributor
✅ No release notes required |
T-Gro
force-pushed
the
fix/designtimeTP
branch
4 times, most recently
from
df6cb94 to
9e93c70
Compare
Contributor
|
🔍 Tooling Safety Check — Affects-Build-Infra, Affects-Design-Time
|
github-actions
Bot
added
⚠️ Affects-Design-Time
T-Gro
force-pushed
the
fix/designtimeTP
branch
2 times, most recently
from
7293dad to
4b67d9b
Compare
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Packing an F# library that activates a design-time type provider via a
ProjectReferencemarkedIsFSharpDesignTimeProvider="true"no longer included the provider assembly in the package (regressed by #18929).dotnet packcollects content in an inner build withBuildProjectReferences=false, where@(_ResolvedProjectReferencePaths)is empty, so theAfterTargets="ResolveReferences"form ofPackageFSharpDesignTimeToolsproduced nothing. It now resolves the provider withGetTargetPath— no reference build (safe underpack --no-build, no NETSDK1085) and no earlyResolveReferences(so #18924 stays fixed). Registration moves back to evaluation time.