Handle remaining interpolated-string forms adjacent to '=' (#16696)#19984
Open
edgarfgp wants to merge 3 commits into
Open
Handle remaining interpolated-string forms adjacent to '=' (#16696)#19984edgarfgp wants to merge 3 commits into
edgarfgp wants to merge 3 commits into
Conversation
Contributor
❗ Release notes requiredYou can open this PR in browser to add release notes: open in github.dev
|
d43927a to
925d53a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #19820, which fixed
=adjacent to a$"..."interpolated string. That fix also covered=$"""..."""for free, but the verbatim and multi-dollar forms still lexed=$@,=@$,=$$as the invalid operator=$.This extends the same rule to those forms.
Before
After
The lexer matches
=plus the interpolated-string opener, consumes only the=, and rewinds so the regular interpolated-string lexer handles the rest. Operators containing$are still rejected with FS0035, unchanged.