-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Add public SentencePieceTokenizer factory methods for Unigram from vocab list and tokenizer.json #7625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Copilot
wants to merge
15
commits into
main
Choose a base branch
from
copilot/add-sentencepiece-tokenizer-api
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add public SentencePieceTokenizer factory methods for Unigram from vocab list and tokenizer.json #7625
Changes from 3 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
ff40b11
Initial plan
Copilot 862be32
Add public SentencePieceTokenizer.Create(vocab) and CreateFromTokeniz…
Copilot 112ee2b
Fix BOS/EOS positional fallback, normalizer type validation, and prep…
Copilot 7e32c05
Fix null normalizer guard, recursive Sequence support, BOS/EOS valida…
Copilot 057cd46
Generalize SentencePiece special tokens to prefix/suffix lists with p…
ericstj 0725072
Support JSON-only Unigram normalizer chains and broaden tokenizer.jso…
ericstj 96961f8
Address Copilot review: byte_fallback init, Metaspace replacement, doc
ericstj 4de649c
Address Copilot review round 2: Nmt, processor affix validation, cleanup
ericstj bc46cb8
Address Copilot review round 3: clarify charsmap comment, label missi…
ericstj eadbf7d
Address Copilot review round 4: byte-offset gating, base64 + unk_id v…
ericstj 1b3e19a
Address Copilot review round 5: validate unk_id and vocab entry value…
ericstj be2f36c
Address Copilot review round 6: validate JSON value kinds across the …
ericstj 6f361d6
Address Copilot review round 7: validate template special-token id co…
ericstj 45f5fd2
Address Copilot review round 8: remove redundant casts in tests
ericstj e1ff3c5
Address Copilot review round 9: guard normalizer Build value kinds
ericstj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.