[automated] Merge branch 'main' => 'net11.0'#34793
Closed
github-actions[bot] wants to merge 2 commits into
Closed
Conversation
…#34265) <!-- Please let the below note in for people that find this PR --> > [!NOTE] > Are you waiting for the changes in this PR to be merged? > It would be very helpful if you could [test the resulting artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from this PR and let us know in a comment if this change resolves your issue. Thank you! ## Summary Adds a standalone `code-review` skill for reviewing PR code changes with MAUI-specific domain knowledge, modeled after [dotnet/android's android-reviewer skill](https://github.com/dotnet/android/tree/main/.github/skills/android-reviewer). ### What's included **`.github/skills/code-review/SKILL.md`** (196 lines) — Review workflow: - Independence-first methodology (read code before PR description to avoid anchoring bias) - 6-step workflow: gather context → load rules → independent assessment → reconcile with PR narrative → check CI → devil's advocate verdict - Three verdicts: `LGTM`, `NEEDS_CHANGES`, `NEEDS_DISCUSSION` - Optional multi-model review for diverse perspectives - Output constraints: don't pile on, don't flag what CI catches **`.github/skills/code-review/references/review-rules.md`** (345 lines) — Domain knowledge: - **22 sections** of review rules distilled from real FTE code reviews - **138 PR citations** linking each rule to the PR where the pattern was identified - Sourced from **366 PRs**: top 142 most-discussed PRs (2,883 review comments), 30 reverted PRs, 50 candidate-branch failures, 64 regression fixes - Covers: handler lifecycle, memory leaks, safe area, layout, platform code, Android/iOS/Windows specifics, navigation, CollectionView, threading, XAML, testing, performance, error handling, API design, images, gestures, build, accessibility - §21 Regression Prevention — lessons from reverts and candidate failures - §22 Component Risk Table — ranking the most regression-prone components ### Design decisions - **Separation of concerns**: SKILL.md = workflow, review-rules.md = knowledge (follows Android's pattern) - **Standalone**: Can be invoked directly by users or by other agents. No coupling to the PR agent pipeline. - **Data-driven**: Every rule traces to a real PR where a senior maintainer flagged the pattern. No generic advice. ### Changes to copilot-instructions.md - Added "Opening PRs" section with required NOTE block template - Added code-review skill to the skills listing - Minor reformatting of existing documentation sections --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Jakub Florkowski <kubaflo123@gmail.com>
Reset patterns: - global.json - NuGet.config - eng/Version.Details.xml - eng/Versions.props - eng/common/*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I detected changes in the main branch which have not been merged yet to net11.0. I'm a robot and am configured to help you automatically keep net11.0 up to date, so I've opened this PR.
This PR merges commits made on main by the following committers:
Instructions for merging from UI
This PR will not be auto-merged. When pull request checks pass, complete this PR by creating a merge commit, not a squash or rebase commit.
If this repo does not allow creating merge commits from the GitHub UI, use command line instructions.
Instructions for merging via command line
Run these commands to merge this pull request from the command line.
or if you are using SSH
After PR checks are complete push the branch
Instructions for resolving conflicts
Instructions for updating this pull request
Contributors to this repo have permission update this pull request by pushing to the branch 'merge/main-to-net11.0'. This can be done to resolve conflicts or make other changes to this pull request before it is merged.
The provided examples assume that the remote is named 'origin'. If you have a different remote name, please replace 'origin' with the name of your remote.
or if you are using SSH
Contact .NET Core Engineering (dotnet/dnceng) if you have questions or issues.
Also, if this PR was generated incorrectly, help us fix it. See https://github.com/dotnet/arcade/blob/main/.github/workflows/scripts/inter-branch-merge.ps1.