[automated] Merge branch 'vs17.14' => 'vs18.0'#14112
Open
github-actions[bot] wants to merge 5 commits into
Open
[automated] Merge branch 'vs17.14' => 'vs18.0'#14112github-actions[bot] wants to merge 5 commits into
github-actions[bot] wants to merge 5 commits into
Conversation
This pull request updates the following dependencies [marker]: <> (Begin:15388ba0-faaf-4906-bba2-a9b719e812a4) ## From https://github.com/dotnet/arcade - **Subscription**: [15388ba0-faaf-4906-bba2-a9b719e812a4](https://maestro.dot.net/subscriptions?search=15388ba0-faaf-4906-bba2-a9b719e812a4) - **Build**: [20260528.4](https://dev.azure.com/dnceng/internal/_build/results?buildId=2986526) ([316238](https://maestro.dot.net/channel/5175/github:dotnet:arcade/build/316238)) - **Date Produced**: May 28, 2026 9:22:26 PM UTC - **Commit**: [9cf79e2a2ecf95c9b2aa6a321baaea009753e356](dotnet/arcade@9cf79e2) - **Branch**: [release/9.0](https://github.com/dotnet/arcade/tree/release/9.0) [DependencyUpdate]: <> (Begin) - **Dependency Updates**: - From [9.0.0-beta.26261.1 to 9.0.0-beta.26278.4][1] - Microsoft.SourceBuild.Intermediate.arcade - Microsoft.DotNet.Arcade.Sdk - Microsoft.DotNet.XliffTasks - Microsoft.DotNet.XUnitExtensions [1]: dotnet/arcade@6c1a2a6...9cf79e2 [DependencyUpdate]: <> (End) [marker]: <> (End:15388ba0-faaf-4906-bba2-a9b719e812a4) --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Gang Wang <v-gaw@microsoft.com>
This pull request updates the following dependencies [marker]: <> (Begin:15388ba0-faaf-4906-bba2-a9b719e812a4) ## From https://github.com/dotnet/arcade - **Subscription**: [15388ba0-faaf-4906-bba2-a9b719e812a4](https://maestro.dot.net/subscriptions?search=15388ba0-faaf-4906-bba2-a9b719e812a4) - **Build**: [20260601.4](https://dev.azure.com/dnceng/internal/_build/results?buildId=2988921) ([316590](https://maestro.dot.net/channel/5175/github:dotnet:arcade/build/316590)) - **Date Produced**: June 1, 2026 8:52:28 AM UTC - **Commit**: [efce34e9f9f25af27e2b471fbbf8c21f1ac2e318](dotnet/arcade@efce34e) - **Branch**: [release/9.0](https://github.com/dotnet/arcade/tree/release/9.0) [DependencyUpdate]: <> (Begin) - **Dependency Updates**: - From [9.0.0-beta.26278.4 to 9.0.0-beta.26301.4][1] - Microsoft.SourceBuild.Intermediate.arcade - Microsoft.DotNet.Arcade.Sdk - Microsoft.DotNet.XliffTasks - Microsoft.DotNet.XUnitExtensions [1]: dotnet/arcade@9cf79e2...efce34e [DependencyUpdate]: <> (End) [marker]: <> (End:15388ba0-faaf-4906-bba2-a9b719e812a4) --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Nguyen Huu Linh <huulinhnguyen99@gmail.com>
### Context
On the `vs17.14` servicing branch, the official build (pipeline
`MSBuild` / definition `9434`) fails in the `OptProf - Build VS
bootstrapper` step (`MicroBuildBuildVSBootstrapper@3`) with `Failed to
obtain an access token from the VSDrop Managed Identity`. `vs17.14` is
in servicing and no longer needs to collect fresh OptProf data, so this
disables OptProf collection (including the failing bootstrapper build)
while continuing to apply the last-collected optimization data so
shipped binaries stay optimized.
### Changes Made
- Changed the `enableOptProf` parameter default from `true` to `false`
in `.vsts-dotnet.yml`, which gates off all OptProf-collection steps
(`MicroBuildOptProfPlugin@6`, `MicroBuildBuildVSBootstrapper@3`,
`VisualStudio.BuildIbcTrainingSettings`, ProfilingInputs publish,
`ready-for-training` tag).
- Removed the `${{ if eq(parameters.enableOptProf, false) }}` block in
`.vsts-dotnet.yml` that forced `SkipApplyOptimizationData` to `true`,
decoupling data *collection* from data *application*;
`SkipApplyOptimizationData` is now governed solely by the pipeline
variable (default `false` = keep applying existing data).
- Gated the `OptProf - Publish Artifact: MicroBuildOutputs` task in
`azure-pipelines/.vsts-dotnet-build-jobs.yml` on `${{
parameters.enableOptProf }}`, since `BootstrapperInfo.json` is only
produced when the bootstrapper runs.
### Testing
- Validated both YAML files parse successfully.
- Pending: queue official build `9434` on the merged `vs17.14` branch
and confirm `OptProf - Build VS bootstrapper` is skipped, the build is
green, and the `Build` step log shows optimization data is still applied
(i.e., `EnableNgenOptimization` is not set to `false`).
- Result: <fill in build link / outcome after the official run>.
### Notes
- `enableOptProf` remains a queue-time parameter, so OptProf collection
can be re-enabled per-run if the VSDrop managed-identity/channel issue
is later resolved.
- No product code changes; VSSetup/packages are still produced, so
downstream VS insertion is unaffected.
---------
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…rbf + HashCode 6.0) (#14127) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Rainer Sigwald <raines@microsoft.com>
Contributor
Author
|
This pull request has been updated. This PR merges commits made on vs17.14 by the following committers: |
ViktorHofer
approved these changes
Jul 1, 2026
AlesProkop
approved these changes
Jul 1, 2026
Member
|
@rainersigwald please take a look at these failures. I'm a bit confused on what versions we want here for vs18.0 vs what NuGet dependencies bring in. This is due to 25f168c flowing forward. |
52b9693 to
46d46aa
Compare
Member
|
I don't think we need to preserve any of the complexity from 17.14 here, which enabled a much easier way to resolve the conflicts: don't. That is, ❯ git reset --hard origin/vs18.0
HEAD is now at fa030cda17 [vs18.0] Update dependencies from dotnet/arcade (#13984)
❯ git merge -s ours --no-ff --no-commit origin/vs17.14
Automatic merge went well; stopped before committing as requested
❯ git cherry-pick -n fe00274ead
Auto-merging eng/Versions.props
❯ git commit -m "Merge branch 'vs17.14' into 'vs18.0'"
[merge/vs17.14-to-vs18.0 46d46aa98b] Merge branch 'vs17.14' into 'vs18.0' |
rainersigwald
approved these changes
Jul 2, 2026
Member
|
Interesting. Why don't we need 25f168c in 18.0? Isn't it weird to not have 10.0.x binding redirects and runtime assemblies there when they are present in 17.14? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I detected changes in the vs17.14 branch which have not been merged yet to vs18.0. I'm a robot and am configured to help you automatically keep vs18.0 up to date, so I've opened this PR.
This PR merges commits made on vs17.14 by the following committers:
Instructions for merging from UI
This PR will not be auto-merged. When pull request checks pass, complete this PR by creating a merge commit, not a squash or rebase commit.
If this repo does not allow creating merge commits from the GitHub UI, use command line instructions.
Instructions for merging via command line
Run these commands to merge this pull request from the command line.
or if you are using SSH
After PR checks are complete push the branch
Instructions for resolving conflicts
Instructions for updating this pull request
Contributors to this repo have permission update this pull request by pushing to the branch 'merge/vs17.14-to-vs18.0'. This can be done to resolve conflicts or make other changes to this pull request before it is merged.
The provided examples assume that the remote is named 'origin'. If you have a different remote name, please replace 'origin' with the name of your remote.
or if you are using SSH
Contact .NET Core Engineering (dotnet/dnceng) if you have questions or issues.
Also, if this PR was generated incorrectly, help us fix it. See https://github.com/dotnet/arcade/blob/main/.github/workflows/scripts/inter-branch-merge.ps1.