Improve TextLine and line table performance by packing existing data into unused bits#83000

Merged

333fred merged 39 commits into

dotnet:mainfrom

CyrusNajmabadi:textline-encoding

Apr 16, 2026

Commits on Apr 1, 2026

Add exhaustive TextLine newline tests across all SourceText types

Cyrus Najmabadi
authored and
Cyrus Najmabadi
committed
Merge _start/_endIncludingBreaks into a single ulong in TextLine

authored and
Cyrus Najmabadi
committed
Replace magic numbers in TextLine with named constants

authored and
Cyrus Najmabadi
committed
Simplify _data encoding: length field always includes line break

authored and
Cyrus Najmabadi
committed
Fix sign-extension warnings in _data packing

authored and
Cyrus Najmabadi
committed
Pass known line break length to FromSpanUnsafe in CompositeText and SubText

authored and
Cyrus Najmabadi
committed
Encode line break length in _lineStarts entries in SourceText.LineInfo

authored and
Cyrus Najmabadi
committed
Remove original FromSpanUnsafe.

CyrusNajmabadi
authored and
Cyrus Najmabadi
committed
Simplify TextLine encoding now that line break length is always known

authored and
Cyrus Najmabadi
committed
Simplify

CyrusNajmabadi
authored and
Cyrus Najmabadi
committed
Apply suggestions from code review

CyrusNajmabadi
authored and
Cyrus Najmabadi
committed
Remove .claude/settings.local.json; add .claude/ to .gitignore

authored and
Cyrus Najmabadi
committed
Extract GetLineStart helper in LineInfo to reduce repetition

authored and
Cyrus Najmabadi
committed
Extract PackEntry helper in LineInfo; add comment on lineBreakLen in SubText

authored and
Cyrus Najmabadi
committed
Use 1 bit instead of 2 for prior line break length in _lineStarts

authored and
Cyrus Najmabadi
committed
Apply suggestion from @CyrusNajmabadi

CyrusNajmabadi
authored and
Cyrus Najmabadi
committed
Add internal LineBreakLength property to TextLine; use it in CompositeText

authored and
Cyrus Najmabadi
committed
Assert priorLineBreakLength is 1 or 2 in PackEntry

authored and
Cyrus Najmabadi
committed
Update LargeText.ParseLineStarts to use SegmentedList<uint> encoding

authored and
Cyrus Najmabadi
committed
Update pattern

CyrusNajmabadi
authored and
Cyrus Najmabadi
committed
Clarify LineInfo encoding comments: top bit is a \r\n boolean flag

Cyrus Najmabadi
authored and
Cyrus Najmabadi
committed
Add braces around outer foreach loops with multi-line bodies

Cyrus Najmabadi
authored and
Cyrus Najmabadi
committed
Remove abbreviated variable names in TextLineNewLineTests

Cyrus Najmabadi
authored and
Cyrus Najmabadi
committed
Use InterestingContents for CompositeText all-split-points test

Cyrus Najmabadi
authored and
Cyrus Najmabadi
committed
Use InterestingContents for CompositeText three-way split test

Cyrus Najmabadi
authored and
Cyrus Najmabadi
committed
Simplify encoding implementation

Cyrus Najmabadi
authored and
Cyrus Najmabadi
committed
Simplify encoding and add TextLine Equals/GetHashCode tests

Cyrus Najmabadi
authored and
Cyrus Najmabadi
committed
Fix xUnit1026: prefix unused newLineLength parameters with underscore

Cyrus Najmabadi
authored and
Cyrus Najmabadi
committed
Fix xUnit1026: use InlineData instead of AllNewlines for chunk boundary tests

Cyrus Najmabadi
authored and
Cyrus Najmabadi
committed

Commits on Apr 2, 2026

Merge remote-tracking branch 'upstream/main' into textline-encoding

Cyrus Najmabadi
authored and
Cyrus Najmabadi
committed
Address PR feedback

Cyrus Najmabadi
authored and
Cyrus Najmabadi
committed
Restore UTF-8 BOM on SourceText.cs and TextLine.cs

Cyrus Najmabadi
authored and
Cyrus Najmabadi
committed
Restore UTF-8 BOM on SubText.cs

Cyrus Najmabadi
authored and
Cyrus Najmabadi
committed

Commits on Apr 13, 2026

Apply suggestion from @CyrusNajmabadi
CyrusNajmabadi
authored
Merge remote-tracking branch 'upstream/main' into textline-encoding

Cyrus Najmabadi
authored and
Cyrus Najmabadi
committed
Rename PositionMask to RawValueMask for clarity

Cyrus Najmabadi
authored and
Cyrus Najmabadi
committed

Commits on Apr 16, 2026

Update src/Compilers/Core/Portable/Text/SourceText.cs

CyrusNajmabadi
and
333fred
authored
Merge remote-tracking branch 'upstream/main' into textline-encoding

Cyrus Najmabadi
authored and
Cyrus Najmabadi
committed
git pushMerge branch 'textline-encoding' of github.com:CyrusNajmabadi/roslyn into textline-encoding # Please enter a commit message to explain why this merge is necessary, # especially if it merges…

Cyrus Najmabadi
authored and
Cyrus Najmabadi
committed