Update closed class from main#83059
Merged
RikkiGibson merged 564 commits intoApr 8, 2026
Merged
Conversation
…ature Status (dotnet#82564) Updates the reviewer assignment for the Unions feature in `docs/Language Feature Status.md`, replacing `333fred` with `jjonescz` as the second reviewer. <!-- START COPILOT CODING AGENT TIPS --> --- 💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more [Copilot coding agent tips](https://gh.io/copilot-coding-agent-tips) in the docs. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: phil-allen-msft <32652734+phil-allen-msft@users.noreply.github.com>
… Build ID 2916924 (dotnet#82594) This is the pull request automatically created by the OneLocBuild task in the build process to check-in localized files generated based upon translation source files (.lcl files) handed-back from the downstream localization pipeline. If there are issues in translations, visit https://aka.ms/icxLocBug and log bugs for fixes. The OneLocBuild wiki is https://aka.ms/onelocbuild and the localization process in general is documented at https://aka.ms/AllAboutLoc.
…otnet#82508) In dotnet#79964 we [removed a check](https://github.com/dotnet/roslyn/pull/79964/changes#diff-07399f17a690c95d4e31689e1023676fa4b43d37e86775b6611bd8e1f170de6aL280-L281) for whether a non-compiler build error should be reported to the Error List. This PR restores that check. It also adds an in-process cache of diagnostic descriptors so that it can synchronously determine whether a diagnostic id is supported. Fixes dotnet#81109 Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2695780
[main] Source code updates from dotnet/dotnet - Remove unused local function
Allow ExperimentalUrl on syntax kinds and apply it only to transitional kind-taking SyntaxFactory overloads, avoiding broad experimental annotation for existing node APIs.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
When we bind for return type inference, we don't yet know if the body of the lambda will be a `Task`/`ValueTask`, so we can't say for certain whether runtime async will be enabled in the lambda. Therefore, when we come back to do real binding, and we do know for certain that the lambda is runtime async capable, we need to rebind with runtime async enabled. Fixes dotnet#82551. Relates to test plan dotnet#75960
We already have a Linux leg running in helix. The single machine run of Linux is just to ensure we haven't broken the test runner's ability to run tests locally. This repurposes it for the Spanish locale tests that run for each PR. Also, moves the Windows Spanish CI leg to run on rolling builds.
[main] Update dependencies from dotnet/arcade
…#82629) Introduce IFSharpInlineHintsService2 to enable F# inline hints providers to handle displayAllOverride. Update FSharpInlineHintsService to prefer the new interface if available, with fallback to the legacy interface. Adjust MEF constructor and GetInlineHintsAsync logic accordingly. Update public API file to reflect new interface and method. This enhances flexibility and feature support for F# inline hints in Roslyn. Fixes dotnet#82614
…dotnet#81994) - Stop resx source generator from declaring type with original name when overridden - Avoid emitting illegal namespace identifiers when resx file is not under the project directory by using `Link` metadata or removing the non-relative path. This change deletes a block of code that is commented as being necessary to support NativeAOT. I have tested a NativeAOT app with these changes and it works. The source generator is also producing code more similar to the old resx SFG, so we should be quite confident it will run correctly. Fixes dotnet#81973 Fixes dotnet#81991 --------- Co-authored-by: Joey Robichaud <joseph.robichaud@microsoft.com> Co-authored-by: Phil Allen <phillipa@microsoft.com>
…ection (dotnet#82609) When connecting to the compiler server fails due to a timeout, pipe ownership mismatch, or other exception, the previous `LogException`/`LogError` calls emitted messages prefixed with `"Error Error:"` or `"Error:"`. This matches the canonical error pattern that MSBuild's `Exec` task detects in process output, causing it to surface a build error — even though these are transient, recoverable conditions where the compiler falls back gracefully to the command-line tool. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: jjonescz <3669664+jjonescz@users.noreply.github.com>
Introduced in dotnet/dotnet#4671. Broke our VS builds.
[main] Source code updates from dotnet/dotnet
…ported" (dotnet#82638) Reverts dotnet#82508 --------- Co-authored-by: Jan Jones <janjones@microsoft.com>
Championed proposal: dotnet/csharplang#9662 Speclet: https://github.com/dotnet/csharplang/blob/main/proposals/unions.md Test plan: dotnet#81074 The last commit packs enum values
RikkiGibson
removed
Needs API Review
jjonescz
approved these changes
Apr 8, 2026
Contributor
|
@RikkiGibson You might want to pick up changes from #82859 too. This is an exhaustiveness check fix that hasn't made it to main yet. |
Member
Author
|
Merged in commit b903dcc. |
dotnet-policy-service
Bot
added
VSCode
Needs API Review
RikkiGibson
removed
Needs API Review
Contributor
It feels like you pulled too much. I was suggesting to cherry-pick the commit |
RikkiGibson
force-pushed
the
update-closed-class-from-main
branch
from
c6f435e to
0f1f592
Compare
dotnet-policy-service
Bot
added
VSCode
Needs API Review
Contributor
|
This PR modifies public API files. Please follow the instructions at https://github.com/dotnet/roslyn/blob/main/docs/contributing/API%20Review%20Process.md for ensuring all public APIs are reviewed before merging. |
RikkiGibson
merged commit ca9894f
into
dotnet:features/closed-class
28 of 29 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolved merge conflicts in d904dd7
Updated error codes in test baselines in ef45ef8
Microsoft Reviewers: Open in CodeFlow