Skip to content

Commit 15d0d2f

Browse files
kotlarmilosCopilot
andcommitted
Close out #124344: clear stale Apple-mobile CoreCLR test exclusions
Removes 33 stale [ActiveIssue("...124344...")] decorations across 19 library test files (all sub-issues for interpreter codegen, dynamic-code reporting, RefEmit/Moq, and virtual delegate dispatch are resolved upstream). Drops the simulator-only ItemGroup in src/libraries/tests.proj that excluded 10 test projects on iossimulator/tvossimulator/maccatalyst CoreCLR under the now-closed #124044. Fixes #127463 by running DCS_DeeplyLinkedData on a 16 MB-stack worker thread (matching the precedent in System.Threading.Thread tests) so the 513-deep linked chain no longer exhausts the iOS default ~512 KB main-thread stack; the underlying DataContractSerializer dynamic-method recursion depth is unchanged. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent 129d627 commit 15d0d2f

21 files changed

Lines changed: 31 additions & 57 deletions

File tree

src/libraries/Microsoft.Extensions.DependencyModel/tests/CompilationLibraryTests.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ public class CompilationLibraryTests
1515
{
1616
// Moq heavily utilizes RefEmit, which does not work on most aot workloads
1717
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsReflectionEmitSupported))]
18-
[ActiveIssue("https://github.com/dotnet/runtime/issues/124344", typeof(PlatformDetection), nameof(PlatformDetection.IsAppleMobile), nameof(PlatformDetection.IsCoreCLR))]
1918
public void ResolveReferencePathsAcceptsCustomResolvers()
2019
{
2120
var fail = new Mock<ICompilationAssemblyResolver>();

src/libraries/Microsoft.Extensions.DependencyModel/tests/CompositeResolverTests.cs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ public class CompositeResolverTests
1616
{
1717
// Moq heavily utilizes RefEmit, which does not work on most aot workloads
1818
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsReflectionEmitSupported))]
19-
[ActiveIssue("https://github.com/dotnet/runtime/issues/124344", typeof(PlatformDetection), nameof(PlatformDetection.IsAppleMobile), nameof(PlatformDetection.IsCoreCLR))]
2019
public void ReturnsFirstSuccessfulResolve()
2120
{
2221
var fail = new Mock<ICompilationAssemblyResolver>();
@@ -48,7 +47,6 @@ public void ReturnsFirstSuccessfulResolve()
4847

4948
// Moq heavily utilizes RefEmit, which does not work on most aot workloads
5049
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsReflectionEmitSupported))]
51-
[ActiveIssue("https://github.com/dotnet/runtime/issues/124344", typeof(PlatformDetection), nameof(PlatformDetection.IsAppleMobile), nameof(PlatformDetection.IsCoreCLR))]
5250
public void PassesLibraryToAllResolvers()
5351
{
5452
var fail = new Mock<ICompilationAssemblyResolver>();
@@ -70,7 +68,6 @@ public void PassesLibraryToAllResolvers()
7068

7169
// Moq heavily utilizes RefEmit, which does not work on most aot workloads
7270
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsReflectionEmitSupported))]
73-
[ActiveIssue("https://github.com/dotnet/runtime/issues/124344", typeof(PlatformDetection), nameof(PlatformDetection.IsAppleMobile), nameof(PlatformDetection.IsCoreCLR))]
7471
public void PopulatedAssemblies()
7572
{
7673
var fail = new Mock<ICompilationAssemblyResolver>();

src/libraries/System.Diagnostics.FileVersionInfo/tests/System.Diagnostics.FileVersionInfo.Tests/FileVersionInfoTest.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ public partial class FileVersionInfoTest : FileCleanupTestBase
1818
private const string TestNotFoundFileName = "notfound.dll";
1919

2020
[Fact]
21-
[ActiveIssue("https://github.com/dotnet/runtime/issues/124344", typeof(PlatformDetection), nameof(PlatformDetection.IsAppleMobile), nameof(PlatformDetection.IsCoreCLR))]
2221
public void FileVersionInfo_CustomManagedAssembly()
2322
{
2423
// Assembly1.dll

src/libraries/System.Diagnostics.StackTrace/tests/DiagnosticMethodInfoTests.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,6 @@ public static IEnumerable<object[]> Create_OpenDelegate_TestData()
7171
}
7272

7373
[Theory]
74-
[ActiveIssue("https://github.com/dotnet/runtime/issues/124344", typeof(PlatformDetection), nameof(PlatformDetection.IsAppleMobile), nameof(PlatformDetection.IsCoreCLR))]
7574
[MemberData(nameof(Create_OpenDelegate_TestData))]
7675
public void Create_OpenDelegate(Delegate del, string expectedName, string expectedTypeName)
7776
{

src/libraries/System.Numerics.Tensors/tests/TensorPrimitives.Generic.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -571,7 +571,6 @@ public void SpanDestinationFunctions_SpecialValues(SpanDestinationDelegate tenso
571571

572572
[Theory]
573573
[MemberData(nameof(SpanDestinationFunctionsToTest))]
574-
[ActiveIssue("https://github.com/dotnet/runtime/issues/124344", typeof(PlatformDetection), nameof(PlatformDetection.IsAppleMobile), nameof(PlatformDetection.IsCoreCLR))]
575574
public void SpanDestinationFunctions_ValueRange(SpanDestinationDelegate tensorPrimitivesMethod, Func<T, T> expectedMethod, T? tolerance = null)
576575
{
577576
Assert.All(VectorLengthAndIteratedRange(ConvertFromSingle(-100f), ConvertFromSingle(100f), ConvertFromSingle(3f)), arg =>

src/libraries/System.Private.Xml/tests/Readers/CharCheckingReader/CharReaderTests.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ public partial class CharCheckingReaderTest : CGenericTestModule
1111
{
1212
[Theory]
1313
[XmlTests(nameof(Create))]
14-
[ActiveIssue("https://github.com/dotnet/runtime/issues/124344", typeof(PlatformDetection), nameof(PlatformDetection.IsAppleMobile), nameof(PlatformDetection.IsCoreCLR))]
1514
public void RunTests(XunitTestCase testCase)
1615
{
1716
testCase.Run();

src/libraries/System.Private.Xml/tests/XmlSerializer/XmlSerializerTests.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2689,7 +2689,6 @@ public static void Xml_TypeWithSpecialCharacterInStringMember()
26892689
#endif
26902690
[ActiveIssue("https://github.com/dotnet/runtime/issues/34072", TestRuntimes.Mono)]
26912691
[ActiveIssue("https://github.com/dotnet/runtime/issues/95928", typeof(PlatformDetection), nameof(PlatformDetection.IsReadyToRunCompiled))]
2692-
[ActiveIssue("https://github.com/dotnet/runtime/issues/124344", typeof(PlatformDetection), nameof(PlatformDetection.IsAppleMobile), nameof(PlatformDetection.IsCoreCLR))]
26932692
public static void Xml_TypeInCollectibleALC()
26942693
{
26952694
ExecuteAndUnload("SerializableAssembly.dll", "SerializationTypes.SimpleType", out var weakRef);

src/libraries/System.Private.Xml/tests/Xslt/XslCompiledTransformApi/XslCompiledTransform.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -600,7 +600,6 @@ public void XmlResolver3(object param, XslInputType xslInputType, ReaderType rea
600600
[InlineData(XslInputType.Navigator, ReaderType.XmlValidatingReader, OutputType.Writer, NavType.XPathDocument)]
601601
[InlineData(XslInputType.Navigator, ReaderType.XmlValidatingReader, OutputType.TextWriter, NavType.XPathDocument)]
602602
[Theory]
603-
[ActiveIssue("https://github.com/dotnet/runtime/issues/124344", typeof(PlatformDetection), nameof(PlatformDetection.IsAppleMobile), nameof(PlatformDetection.IsCoreCLR))]
604603
public void XmlResolver7(XslInputType xslInputType, ReaderType readerType, OutputType outputType, NavType navType)
605604
{
606605
using (new AllowDefaultResolverContext())
@@ -2549,7 +2548,6 @@ public void XmlResolver3(object param, XslInputType xslInputType, ReaderType rea
25492548
[InlineData(XslInputType.Navigator, ReaderType.XmlValidatingReader, OutputType.Writer, NavType.XPathDocument)]
25502549
[InlineData(XslInputType.Navigator, ReaderType.XmlValidatingReader, OutputType.TextWriter, NavType.XPathDocument)]
25512550
[Theory]
2552-
[ActiveIssue("https://github.com/dotnet/runtime/issues/124344", typeof(PlatformDetection), nameof(PlatformDetection.IsAppleMobile), nameof(PlatformDetection.IsCoreCLR))]
25532551
public void XmlResolver5(XslInputType xslInputType, ReaderType readerType, OutputType outputType, NavType navType)
25542552
{
25552553
using (new AllowDefaultResolverContext())

src/libraries/System.Private.Xml/tests/Xslt/XslCompiledTransformApi/XsltApiV2.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@ public enum NavType
3838
//
3939
////////////////////////////////////////////////////////////////
4040
[ConditionalClass(typeof(PlatformDetection), nameof(PlatformDetection.IsReflectionEmitSupported))]
41-
[ActiveIssue("https://github.com/dotnet/runtime/issues/124344", typeof(PlatformDetection), nameof(PlatformDetection.IsAppleMobile), nameof(PlatformDetection.IsCoreCLR))]
4241
public class XsltApiTestCaseBase2
4342
{
4443
// Generic data for all derived test cases

src/libraries/System.Reflection.Metadata/tests/Metadata/Decoding/CustomAttributeDecoderTests.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,6 @@ public void TestCustomAttributeDecoder()
8686

8787
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.HasAssemblyFiles))]
8888
[ActiveIssue("https://github.com/dotnet/runtime/issues/73593", TestRuntimes.Mono)]
89-
[ActiveIssue("https://github.com/dotnet/runtime/issues/124344", typeof(PlatformDetection), nameof(PlatformDetection.IsAppleMobile), nameof(PlatformDetection.IsCoreCLR))]
9089
public void TestCustomAttributeDecoderUsingReflection()
9190
{
9291
Type type = typeof(HasAttributes);

0 commit comments

Comments
 (0)