Skip to content

Commit 41781d5

Browse files
max-charlambMax CharlambCopilot
authored
Update Microsoft.Diagnostics.Runtime to 4.0.722401 (#127088)
Update ClrMD to the first stable release with cross-bitness address truncation fixes ([microsoft/clrmd#1423](microsoft/clrmd#1423)). ## Changes - **`eng/Versions.props`**: Update `MicrosoftDiagnosticsRuntimeVersion` from `4.0.0-beta.26210.1` to `4.0.722401` (stable release) - **`DumpTestBase.cs`**: Remove the cross-bitness dump test skip added in #127118 — ClrMD 4.0.722401 now correctly handles sign-extended `CLRDATA_ADDRESS` values, enabling 32-bit hosts to read 64-bit dumps ## What was fixed in ClrMD ClrMD 4.0.722401 includes: - `ClrDataAddress` type with explicit sign-extension handling (`FromTargetAddress` / `ToAddress`) - ABI-safe COM vtable marshalling (addresses as `ulong` primitives, not structs) - `unchecked` casts to prevent `OverflowException` on sign-extended 32-bit addresses - Full verification against `sospriv.idl` in dotnet/runtime ## Cross-platform verification xplat cDAC dump tests pass with the skip removed: https://dev.azure.com/dnceng-public/public/_build/results?buildId=1398682&view=ms.vss-test-web.build-test-results-tab Co-authored-by: Max Charlamb <maxcharlamb@microsoft.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent bbccf5e commit 41781d5

2 files changed

Lines changed: 1 addition & 13 deletions

File tree

eng/Versions.props

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@
155155
<NewtonsoftJsonVersion>13.0.3</NewtonsoftJsonVersion>
156156
<NewtonsoftJsonBsonVersion>1.0.2</NewtonsoftJsonBsonVersion>
157157
<MoqVersion>4.18.4</MoqVersion>
158-
<MicrosoftDiagnosticsRuntimeVersion>4.0.0-beta.26210.1</MicrosoftDiagnosticsRuntimeVersion>
158+
<MicrosoftDiagnosticsRuntimeVersion>4.0.722401</MicrosoftDiagnosticsRuntimeVersion>
159159
<AwesomeAssertionsVersion>8.0.2</AwesomeAssertionsVersion>
160160
<FsCheckVersion>2.14.3</FsCheckVersion>
161161
<CommandLineParserVersion>2.9.1</CommandLineParserVersion>

src/native/managed/cdac/tests/DumpTests/DumpTestBase.cs

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -148,18 +148,6 @@ private void EvaluateSkipAttributes(TestConfiguration config, string callerName,
148148

149149
if (_dumpInfo is not null)
150150
{
151-
// Cross-bitness dump reading is not yet supported when a 32-bit host
152-
// tries to read a 64-bit dump (see microsoft/clrmd#1423).
153-
// The reverse (64-bit host reading 32-bit dump) works fine.
154-
bool isDump64Bit = _dumpInfo.Arch is "x64" or "arm64" or "riscv64" or "loongarch64";
155-
bool isHost64Bit = IntPtr.Size == 8;
156-
if (isDump64Bit && !isHost64Bit)
157-
{
158-
throw new SkipTestException(
159-
$"32-bit host cannot read 64-bit dumps: dump is {_dumpInfo.Arch}. " +
160-
$"See microsoft/clrmd#1423.");
161-
}
162-
163151
foreach (SkipOnOSAttribute attr in method.GetCustomAttributes<SkipOnOSAttribute>())
164152
{
165153
if (attr.IncludeOnly is not null)

0 commit comments

Comments
 (0)