Commit 69ff284
[release/10.0] Release Android X509 chain certificate GREFs (#128385)
Backport of #128284 to release/10.0
/cc @simonrozsival
## Customer Impact
- [x] Customer reported
- [ ] Found internally
A customer reported that their app was crashing due to a memory leak in
X509Chain class (JNI global ref table overflow).
## Regression
- [ ] Yes
- [x] No
[If yes, specify when the regression was introduced. Provide the PR or
commit if known.]
## Testing
The new unit test
(ChainTests.BuildChainRepeatedly_DoesNotExhaustGlobalReferences) passes
locally on Android emulator.
## Risk
Low. The change only affects Android and the code path is well covered
by tests.
**IMPORTANT**: If this backport is for a servicing release, please
verify that:
- For .NET 8 and .NET 9: The PR target branch is `release/X.0-staging`,
not `release/X.0`.
- For .NET 10+: The PR target branch is `release/X.0` (no `-staging`
suffix).
## Package authoring no longer needed in .NET 9
**IMPORTANT**: Starting with .NET 9, you no longer need to edit a NuGet
package's csproj to enable building and bump the version.
Keep in mind that we still need package authoring in .NET 8 and older
versions.
---------
Co-authored-by: Simon Rozsival <simon@rozsival.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>1 parent 54047c8 commit 69ff284
1 file changed
Lines changed: 24 additions & 6 deletions
File tree
- src/libraries/Common/src/Interop/Android/System.Security.Cryptography.Native.Android
Lines changed: 24 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
42 | 42 | | |
43 | 43 | | |
44 | 44 | | |
45 | | - | |
46 | | - | |
47 | | - | |
48 | | - | |
49 | 45 | | |
50 | 46 | | |
51 | | - | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
52 | 61 | | |
53 | | - | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
54 | 72 | | |
55 | 73 | | |
56 | 74 | | |
| |||
0 commit comments