Commit cb1a6be
Root inherited MemberData statics against the trimmer on maccatalyst CoreCLR
On maccatalyst-arm64 AllSubsets_CoreCLR (runtime-extra-platforms), ILLink strips
the inherited ConnectedStreamConformanceTests.ReadWrite_Success_MemberData and
CopyToAsync_AllDataCopied_MemberData statics, so xUnit's [MemberData] discovery
throws ArgumentException ("Could not find public static member ...") before the
test body runs, on CryptoStreamTests.ReadWrite_Success and
NetworkStreamTest.CopyToAsync_AllDataCopied.
Override each test to add a [DynamicDependency] root keeping the base statics
alive under trimming. xUnit does not inherit attributes from overridden virtual
methods, so the overrides also restate the base gating: the
IsMultithreadingSupported ConditionalTheory (System.Net.Sockets.Tests runs on
single-threaded wasi in CI) and the LinuxBionic and iOS/tvOS platform skips.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>1 parent c95ffd0 commit cb1a6be
2 files changed
Lines changed: 5 additions & 3 deletions
File tree
- src/libraries
- System.Net.Sockets/tests/FunctionalTests
- System.Security.Cryptography/tests
Lines changed: 3 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
45 | 45 | | |
46 | 46 | | |
47 | 47 | | |
48 | | - | |
| 48 | + | |
49 | 49 | | |
50 | 50 | | |
51 | | - | |
| 51 | + | |
| 52 | + | |
52 | 53 | | |
53 | 54 | | |
54 | 55 | | |
| |||
Lines changed: 2 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
39 | 39 | | |
40 | 40 | | |
41 | 41 | | |
42 | | - | |
| 42 | + | |
| 43 | + | |
43 | 44 | | |
44 | 45 | | |
45 | 46 | | |
| |||
0 commit comments