Update WebAssembly Helix image versions#126524
Conversation
Switch the Browser/WASM and WASI Helix queues to the published Ubuntu 26.04 webassembly images while keeping the oldest 22.04 coverage slot intact. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
There was a problem hiding this comment.
Pull request overview
Updates remaining WebAssembly/WASI Helix queue/image references to Ubuntu 26.04 prereqs images, aligning infra with the repo’s ongoing move off older Ubuntu versions while keeping the “oldest” 22.04 coverage slot intact.
Changes:
- Update Libraries WASI / browser WASM (including Firefox) Helix queues to Ubuntu 26.04.
- Switch
helix_browser_wasm_latestcoverage inhelix-platforms.ymlto Ubuntu 26.04. - Update CoreCLR browser WASM Helix queues (public + internal) to Ubuntu 26.04 and the matching prereqs image.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| eng/pipelines/libraries/helix-queues-setup.yml | Updates Libraries WASI/browser/Firefox WASM Helix queue strings to Ubuntu 26.04 prereqs image. |
| eng/pipelines/helix-platforms.yml | Switches “latest” Browser WASM Helix platform variable from Ubuntu 24.04 to 26.04. |
| eng/pipelines/coreclr/templates/helix-queues-setup.yml | Updates CoreCLR browser WASM public/internal queues and container image to Ubuntu 26.04. |
This comment has been minimized.
This comment has been minimized.
Use the explicit ubuntu-26.04-helix-webassembly-amd64 tag in the Libraries Helix queues for consistency with the other WebAssembly queue definitions. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Update the update-os-coverage skill to treat image-info.dotnet-dotnet-buildtools-prereqs-docker-main.json as the authoritative source for prereqs tags and to prefer architecture-specific aliases when the Helix queue is processor-specific. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
@copilot apply changes based on the comments in this thread |
This comment has been minimized.
This comment has been minimized.
…KILL.md indentation Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/607ac376-be42-4d08-847c-fc0746d7c76f Co-authored-by: richlander <2608468+richlander@users.noreply.github.com>
Applied in cdc46ec:
|
Normalize the public Browser WASM and WASI container queue identifiers to the .Open form so they match the established Helix naming convention and stop triggering repetitive review noise. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
Update the remaining build documentation references to point at the current Azure Linux cross-build images and wording. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Note This review was generated by Copilot. 🤖 Copilot Code Review — PR #126524Holistic AssessmentMotivation: This PR updates WASM/WASI Helix pipeline images from Ubuntu 22.04/24.04 to Ubuntu 26.04, fixes inconsistent Approach: The approach is sound — updating image tags across all three pipeline files (helix-platforms, coreclr helix-queues, libraries helix-queues), fixing pre-existing naming inconsistencies along the way, and codifying lessons learned into the skill documentation. The changes are consistent with existing patterns in the codebase. Summary: Detailed Findings✅ Image Tags Verified — All referenced tags exist in
|
|
/ba-g "Build analysis stuck; failures unrelated." |
> [!NOTE] > This PR was AI/Copilot-generated. Update the release/9.0 WASI and Browser WebAssembly Helix queue image references to the published Ubuntu 26.04 WebAssembly image. - `libraries/helix-queues-setup.yml`: move WASI, Browser WASM, and Browser WASM Firefox to `ubuntu-26.04-helix-webassembly-amd64` - `coreclr/templates/helix-queues-setup.yml`: move Browser WASM to the 26.04 amd64 image while preserving the existing host queue pattern on this branch - exact tag validated in `image-info.dotnet-dotnet-buildtools-prereqs-docker-main.json` Backport of #126524. Ref #125690, #126122 --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
> [!NOTE] > This PR was AI/Copilot-generated. Update the release/8.0 WASI and Browser WebAssembly Helix queue image references to the published Ubuntu 26.04 WebAssembly image. - `libraries/helix-queues-setup.yml`: move WASI, Browser WASM, and Browser WASM Firefox to `ubuntu-26.04-helix-webassembly-amd64` - `coreclr/templates/helix-queues-setup.yml`: move Browser WASM to the 26.04 amd64 image - exact tag validated in `image-info.dotnet-dotnet-buildtools-prereqs-docker-main.json` Backport of #126524. Ref #125690, #126122 --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
> [!NOTE] > This PR was AI/Copilot-generated. main PR #126524. Ref #125690, #126122 # Description Update the release/10.0 WASI and Browser WebAssembly Helix queue image references to the published Ubuntu 26.04 WebAssembly images. - `libraries/helix-queues-setup.yml`: move WASI, Browser WASM, and Browser WASM Firefox to `ubuntu-26.04-helix-webassembly-amd64`; split each entry into public (`.Open`) and internal (non-`.Open`) variants to match the pattern used in `coreclr/templates/helix-queues-setup.yml` - `coreclr/templates/helix-queues-setup.yml`: move Browser WASM public/internal queues from Ubuntu 24.04 to 26.04, using `.Open` suffix for public queue identifiers - exact tag validated in `image-info.dotnet-dotnet-buildtools-prereqs-docker-main.json` # Customer Impact Without this fix, WASI and Browser WebAssembly Helix test runs on release/10.0 would continue using the older Ubuntu 22.04/24.04 WebAssembly images instead of the current Ubuntu 26.04 images. Internal pipeline runs would also incorrectly reference public `.Open` queues, potentially causing test scheduling failures. # Regression No. This updates image versions to stay current with available prereqs images. # Testing Pipeline configuration change only. Validated that the exact container image tag (`ubuntu-26.04-helix-webassembly-amd64`) is present in `image-info.dotnet-dotnet-buildtools-prereqs-docker-main.json`. # Risk Low. This is a Helix queue image version bump with no code changes. The queue identifiers follow the established `.Open` / non-`.Open` convention for public and internal pipelines respectively. # Package authoring no longer needed in .NET 9 IMPORTANT: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version. Keep in mind that we still need package authoring in .NET 8 and older versions. --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
> [!NOTE] > This PR was AI/Copilot-generated. Update the remaining WebAssembly/WASI Helix image references to the published Ubuntu 26.04 prereqs images, and fix public Helix queue identifiers to use the `.Open` suffix convention. - switch Browser WASM `latest` coverage in `helix-platforms.yml` to `ubuntu-26.04-helix-webassembly-amd64` - update CoreCLR browser WASM queues to `Ubuntu.2604.*` and the matching 26.04 image - update Libraries WASI/browser/firefox WASM queues to the 26.04 webassembly image - fix public Browser WASM Helix queue identifiers to use `(Ubuntu.2604.Amd64.Open)` convention (CoreCLR template and `helix-platforms.yml` latest slot) - fix `helix_browser_wasm_oldest` queue identifier to use `(Ubuntu.2204.Amd64.Open)` to match established `.Open` pattern for public queues - keep the `oldest` 22.04 coverage slot otherwise unchanged - fix markdown indentation in `SKILL.md` version-naming conventions section Ref dotnet#126122 --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Note
This PR was AI/Copilot-generated.
Update the remaining WebAssembly/WASI Helix image references to the published Ubuntu 26.04 prereqs images, and fix public Helix queue identifiers to use the
.Opensuffix convention.latestcoverage inhelix-platforms.ymltoubuntu-26.04-helix-webassembly-amd64Ubuntu.2604.*and the matching 26.04 image(Ubuntu.2604.Amd64.Open)convention (CoreCLR template andhelix-platforms.ymllatest slot)helix_browser_wasm_oldestqueue identifier to use(Ubuntu.2204.Amd64.Open)to match established.Openpattern for public queuesoldest22.04 coverage slot otherwise unchangedSKILL.mdversion-naming conventions sectionRef #126122