Skip to content

Only disable StartupHookSupport in non-Debug builds; remove MetadataUpdaterSupport from ILLink.targets #126546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 4 commits into
base: main
Choose a base branch
from
+1 −2
Draft

Only disable StartupHookSupport in non-Debug builds; remove MetadataUpdaterSupport from ILLink.targets #126546

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dba3493
Initial plan
Copilot Apr 4, 2026
e348f99
Only disable StartupHookSupport in non-Debug builds and remove Metada…
Copilot Apr 4, 2026
9e0ba3d
Fix test method name: RespectExplicitValue -> RespectsExplicitValue
Copilot Apr 4, 2026
437bc81
Remove tests from ILLink.Tasks.Tests (this kind of testing belongs in…
Copilot Apr 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/tools/illink/src/ILLink.Tasks/build/Microsoft.NET.ILLink.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,7 @@ Copyright (c) .NET Foundation. All rights reserved.
by default since they may require assemblies, types or members that
could be removed by the ILLink, causing a trimmed app to crash. -->
<PropertyGroup Condition="'$(PublishTrimmed)' == 'true'">
<StartupHookSupport Condition="'$(StartupHookSupport)' == ''">false</StartupHookSupport>
<MetadataUpdaterSupport Condition="'$(MetadataUpdaterSupport)' == ''">false</MetadataUpdaterSupport>
<StartupHookSupport Condition="'$(StartupHookSupport)' == '' and '$(Configuration)' != 'Debug'">false</StartupHookSupport>
<CustomResourceTypesSupport Condition="'$(CustomResourceTypesSupport)' == ''">false</CustomResourceTypesSupport>
<EnableUnsafeBinaryFormatterInDesigntimeLicenseContextSerialization Condition="'$(EnableUnsafeBinaryFormatterInDesigntimeLicenseContextSerialization)' == ''">false</EnableUnsafeBinaryFormatterInDesigntimeLicenseContextSerialization>
<EnableUnsafeBinaryFormatterSerialization Condition="'$(EnableUnsafeBinaryFormatterSerialization)' == ''">false</EnableUnsafeBinaryFormatterSerialization>
Expand Down