Skip to content

Disable ICorProfiler on non-desktop and WASM platforms #126550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AaronRobinsonMSFT merged 6 commits into from
Apr 8, 2026
+10 −3
Merged

Disable ICorProfiler on non-desktop and WASM platforms #126550

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
76d9d02
Disable ICorProfiler on mobile and WASM platforms
AaronRobinsonMSFT Apr 4, 2026
3b4f873
Also exclude tvOS from ICorProfiler support
AaronRobinsonMSFT Apr 4, 2026
7b5e7fc
Update ICorProfiler support check to exclude non-desktop targets and …
AaronRobinsonMSFT Apr 4, 2026
1c34317
Apply suggestion from @AaronRobinsonMSFT
AaronRobinsonMSFT Apr 7, 2026
a375135
Merge branch 'main' into disable-profiler-on-mobile
AaronRobinsonMSFT Apr 7, 2026
5e103e2
Merge branch 'main' into disable-profiler-on-mobile
AaronRobinsonMSFT Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions src/coreclr/clrfeatures.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,14 +46,21 @@ if(NOT DEFINED FEATURE_DBGIPC)
endif()
endif(NOT DEFINED FEATURE_DBGIPC)

# ICorProfiler is supported by default
set(FEATURE_CORPROFILER 1)
if(NOT DEFINED FEATURE_CORPROFILER)
# ICorProfiler isn't supported on non-desktop targets or WASM scenarios
if(NOT CLR_CMAKE_TARGET_ARCH_WASM
# AND NOT CLR_CMAKE_TARGET_ANDROID
# AND NOT CLR_CMAKE_TARGET_MACCATALYST
# AND NOT CLR_CMAKE_TARGET_IOS
Comment thread
AaronRobinsonMSFT marked this conversation as resolved.
AND NOT CLR_CMAKE_TARGET_TVOS)
set(FEATURE_CORPROFILER 1)
endif()
Comment thread
AaronRobinsonMSFT marked this conversation as resolved.
Comment thread
AaronRobinsonMSFT marked this conversation as resolved.
endif()

if(CLR_CMAKE_TARGET_ARCH_WASM)
# FEATURE_INTERPRETER is already enabled by default
set(FEATURE_PORTABLE_ENTRYPOINTS 1)
set(FEATURE_PORTABLE_HELPERS 1)
set(FEATURE_CORPROFILER 0)
endif(CLR_CMAKE_TARGET_ARCH_WASM)

if(CLR_CMAKE_TARGET_BROWSER)
Expand Down
Loading