[clr-ios] Preserve inherited MemberData statics on maccatalyst CoreCLR by kotlarmilos · Pull Request #128409 · dotnet/runtime

kotlarmilos · 2026-05-20T15:33:07Z

Description

On maccatalyst-arm64 AllSubsets_CoreCLR, ILLink strips the inherited ReadWrite_Success_MemberData and CopyToAsync_AllDataCopied_MemberData statics on ConnectedStreamConformanceTests, so xUnit's [MemberData] lookup fails for CryptoStreamTests.ReadWrite_Success and NetworkStreamTest.CopyToAsync_AllDataCopied. Adds a [DynamicDependency] on each derived override to root the base statics, and restores the IsMultithreadingSupported guard on CopyToAsync_AllDataCopied.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

kotlarmilos · 2026-05-20T15:34:56Z

/azp run runtime-extra-platforms

azure-pipelines · 2026-05-20T15:35:14Z

Azure Pipelines successfully started running 1 pipeline(s).

Copilot

Pull request overview

This PR adjusts a handful of library test cases to run (or skip) correctly on newly-enabled CoreCLR Apple mobile test legs by updating xUnit data discovery patterns and adding platform/trimming-related guards.

Changes:

Add/adjust theory data sourcing to avoid xUnit MemberData resolution problems in derived/overridden conformance tests.
Skip or expand existing platform exclusions for tests that rely on desktop-only behaviors (e.g., TPA/fusion log details, reflection emit under aggressive trimming).
Expand an existing ActiveIssue to include MacCatalyst and gate a debugger-proxy test away from NativeAOT.

Show a summary per file

File	Description
src/libraries/System.Security.Cryptography/tests/CryptoStream.cs	Adds an override using explicit `MemberType` for `MemberData` to stabilize conformance theory data discovery.
src/libraries/System.Runtime.Loader/tests/TpaLoadFailureTest.cs	Skips path/fusion-log validation tests on Apple mobile where the assumptions don’t hold.
src/libraries/System.Reflection.Metadata/tests/Metadata/Decoding/CustomAttributeDecoderTests.cs	Expands an `ActiveIssue` platform mask to include MacCatalyst.
src/libraries/System.Net.Sockets/tests/FunctionalTests/NetworkStreamTest.cs	Adds an override to supply `MemberType` for `MemberData` on a conformance theory.
src/libraries/System.Linq.Expressions/tests/DebuggerTypeProxy/ExpressionDebuggerTypeProxyTests.cs	Gates a reflection-heavy theory away from NativeAOT via `ConditionalTheory`.
src/libraries/Microsoft.Extensions.Hosting/tests/UnitTests/Internal/HostTests.cs	Further gates Moq/RefEmit-based tests away from aggressively-trimmed/AOT-like environments.

Copilot's findings

Files reviewed: 6/6 changed files
Comments generated: 1

kotlarmilos · 2026-05-21T10:26:20Z

/azp run runtime-extra-platforms

azure-pipelines · 2026-05-21T10:26:34Z

Azure Pipelines successfully started running 1 pipeline(s).

Copilot

Copilot's findings

Files reviewed: 2/2 changed files
Comments generated: 2

Copilot

Copilot's findings

Files reviewed: 2/2 changed files
Comments generated: 2

…CoreCLR On maccatalyst-arm64 AllSubsets_CoreCLR (runtime-extra-platforms), ILLink strips the inherited ConnectedStreamConformanceTests.ReadWrite_Success_MemberData and CopyToAsync_AllDataCopied_MemberData statics, so xUnit's [MemberData] discovery throws ArgumentException ("Could not find public static member ...") before the test body runs, on CryptoStreamTests.ReadWrite_Success and NetworkStreamTest.CopyToAsync_AllDataCopied. Override each test to add a [DynamicDependency] root keeping the base statics alive under trimming. xUnit does not inherit attributes from overridden virtual methods, so the overrides also restate the base gating: the IsMultithreadingSupported ConditionalTheory (System.Net.Sockets.Tests runs on single-threaded wasi in CI) and the LinuxBionic and iOS/tvOS platform skips. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

CryptoStreamTests wraps in-memory ConnectedStreams.CreateBidirectional(), not sockets, so the LinuxBionic/iOS/tvOS skips (reasoned as UNIX-socket restrictions) do not apply. The sibling ReadWrite_Success_Large override in the same class carries no such skips. The override keeps [Theory], qualified [MemberData], and [DynamicDependency] to root the inherited static MemberData against the trimmer on maccatalyst CoreCLR. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Copilot's findings

Files reviewed: 2/2 changed files
Comments generated: 1

NetworkStreamTest binds TCP loopback sockets; the restriction is the CI sandbox blocking socket binding, not UNIX sockets specifically. Collapse the LinuxBionic and iOS/tvOS skips into a single SkipOnPlatform with a clearer reason. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

azure-pipelines · 2026-06-09T10:47:00Z

No pipelines are associated with this pull request.

kotlarmilos · 2026-06-09T10:48:29Z

/azp list

kotlarmilos · 2026-06-09T10:49:11Z

/azp run runtime-extra-platforms

azure-pipelines · 2026-06-09T10:49:24Z

Azure Pipelines successfully started running 1 pipeline(s).

BrzVlad · 2026-06-12T10:35:12Z

@@ -35,6 +36,11 @@ protected override Task<StreamPair> CreateWrappedConnectedStreamsAsync(StreamPai
        [MemberData(nameof(ReadWrite_Success_Large_MemberData))]
        public override Task ReadWrite_Success_Large(ReadWriteMode mode, int writeSize, bool startWithFlush) => base.ReadWrite_Success_Large(mode, writeSize, startWithFlush);

+        [Theory]
+        [MemberData(nameof(ConnectedStreamConformanceTests.ReadWrite_Success_MemberData), MemberType = typeof(ConnectedStreamConformanceTests))]


This looks weird. It is very common to have MemberData in the test suite and it doesn't seem like we need to special case this everywhere else. I suspect the test assembly is rooted so the linker doesn't trim test code. In this case I suspect the assembly containing ConnectedStreamConformanceTests.ReadWrite_Success_MemberData, aka StreamConformanceTests is not rooted for whatever reason.

Looking a bit deeper, this assembly is specially rooted for a bunch of test suites using it ex: https://github.com/dotnet/runtime/blob/main/src/libraries/System.Runtime/tests/System.IO.FileSystem.Tests/ILLink.Descriptors.xml. I believe we should do the same here

[clr-ios] Fix mobile CoreCLR test failures across libraries

8565792

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings May 20, 2026 15:33

Copilot started reviewing on behalf of kotlarmilos May 20, 2026 15:33 View session

kotlarmilos marked this pull request as draft May 20, 2026 15:33

github-actions Bot added the area-Meta label May 20, 2026

dotnet-policy-service Bot assigned kotlarmilos May 20, 2026

Copilot AI reviewed May 20, 2026

View reviewed changes

Comment thread src/libraries/System.Net.Sockets/tests/FunctionalTests/NetworkStreamTest.cs Outdated

This was referenced May 21, 2026

[ci-scan] Test failure: X509Certificate2CollectionRemoveRangeArray in crossgen2 ReadyToRun pipeline jtschuster/runtime#68

Open

[ci-scan] Skip paltest_pal_sxs_test1 on osx-arm64 (refs #122345) jtschuster/runtime#69

Draft

build-analysis Bot mentioned this pull request May 21, 2026

tvos-arm64 Mono AOT precompilation fails with Invalid IL code for multiple test assemblies #126458

Open

github-actions Bot mentioned this pull request May 21, 2026

[ci-scan] Test failure: CustomAttributeDecoderTests.TestCustomAttributeDecoderGenericUsingReflection on maccatalyst #128450

Open

Merge branch 'main' into kotlarmilos/fix-mobile-clr-test-failures

7e4645a

build-analysis Bot mentioned this pull request Jun 1, 2026

Android WebSocket failure #121518

Open

Merge branch 'main' into kotlarmilos/fix-mobile-clr-test-failures

c95ffd0

Copilot AI review requested due to automatic review settings June 2, 2026 12:27

Copilot started reviewing on behalf of kotlarmilos June 2, 2026 12:27 View session

Copilot AI reviewed Jun 2, 2026

View reviewed changes

Comment thread src/libraries/System.Security.Cryptography/tests/CryptoStream.cs

Comment thread src/libraries/System.Net.Sockets/tests/FunctionalTests/NetworkStreamTest.cs Outdated

Copilot AI review requested due to automatic review settings June 9, 2026 10:02

kotlarmilos force-pushed the kotlarmilos/fix-mobile-clr-test-failures branch from 943dd48 to 89a6b9b Compare June 9, 2026 10:02

Copilot started reviewing on behalf of kotlarmilos June 9, 2026 10:02 View session

Copilot AI reviewed Jun 9, 2026

View reviewed changes

Comment thread src/libraries/System.Security.Cryptography/tests/CryptoStream.cs Outdated

Comment thread src/libraries/System.Net.Sockets/tests/FunctionalTests/NetworkStreamTest.cs Outdated

kotlarmilos force-pushed the kotlarmilos/fix-mobile-clr-test-failures branch from 89a6b9b to cb1a6be Compare June 9, 2026 10:19

Copilot AI review requested due to automatic review settings June 9, 2026 10:30

Copilot started reviewing on behalf of kotlarmilos June 9, 2026 10:30 View session

Conversation

kotlarmilos commented May 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

kotlarmilos commented May 20, 2026

Uh oh!

azure-pipelines Bot commented May 20, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Copilot's findings

Uh oh!

Uh oh!

kotlarmilos commented May 21, 2026

Uh oh!

azure-pipelines Bot commented May 21, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot's findings

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot's findings

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot's findings

Uh oh!

Uh oh!

azure-pipelines Bot commented Jun 9, 2026

Uh oh!

kotlarmilos commented Jun 9, 2026

Uh oh!

This comment was marked as off-topic.

kotlarmilos commented Jun 9, 2026

Uh oh!

azure-pipelines Bot commented Jun 9, 2026

Uh oh!

BrzVlad Jun 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

kotlarmilos commented May 20, 2026 •

edited

Loading

BrzVlad Jun 12, 2026 •

edited

Loading