Add ProjectReference for crossgen2 in tests project

[jtschuster]

To make sure the latest changes for crossgen2 are picked up when building and running the test project locally.

[Copilot]

Pull request overview

This PR updates the ReadyToRun test project to depend on the in-build crossgen2 project so that crossgen2 changes are picked up when building/running the tests.

Changes:

• Add a ProjectReference from ILCompiler.ReadyToRun.Tests to crossgen2_inbuild.csproj (with ReferenceOutputAssembly="false").

[github-actions]

Note

This review was generated by Copilot.

🤖 Copilot Code Review — PR #128414

Holistic Assessment

Motivation: The PR ensures the crossgen2 tool is freshly built before the ReadyToRun tests execute, so tests always pick up the latest crossgen2 changes. This is a legitimate build-ordering concern — without this, stale crossgen2 binaries could cause confusing test failures.

Approach: Using <ProjectReference ... ReferenceOutputAssembly="false" /> is the idiomatic MSBuild pattern for declaring a build-order dependency without adding a runtime assembly reference. This is the right technique.

Summary: ✅ LGTM. A single-line, well-scoped change that uses the correct MSBuild pattern to establish a build dependency. The referenced project (crossgen2_inbuild.csproj) exists at the expected relative path. No correctness, performance, or compatibility concerns.

---

Detailed Findings

✅ Build Dependency Pattern — Correct usage

The ReferenceOutputAssembly="false" attribute ensures this is purely a build-order dependency. The crossgen2 output won't be added to the test project's references or copied to its output directory — it just guarantees crossgen2 is built first. This is consistent with how the test project already consumes crossgen2 via the R2RTest.Crossgen2Dir runtime configuration option pointing to $(RuntimeBinDir)/$(BuildArchitecture)/crossgen2.

✅ File existence verified

src/coreclr/tools/aot/crossgen2/crossgen2_inbuild.csproj exists at the expected relative path from the test project.

Generated by Code Review for issue #128414 · ● 1.5M · ◷