Update SafeProcessHandle.Unix.cs#128416
Open
Neo-vortex wants to merge 1 commit into
Open
Conversation
3 tasks
adamsitnik
reviewed
Jun 15, 2026
adamsitnik
left a comment
Member
There was a problem hiding this comment.
@Neo-vortex thank you for your contribution.
Could you please add a test similar to this one? Then on distros where xdg-open and similar are not available (IIRC one would be Ubuntu run via WSL), we can test the change.
Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: Throw appropriate exception when no shell-open utility is found
fixes : #96565
Problem
Process.GetPathToOpenFile()can returnnullwhen no shell-open utility (e.g.xdg-open,open) is found on the system. The return value was previously used without a null check, which could lead to a null reference further down the call path.Changes
Added a null check on the return value of
GetPathToOpenFile()that throws aWin32ExceptionwithERROR_NO_ASSOCIATIONwhen no utility is found.