[clrinterp] Remove wrong assertion#128548
Merged
Merged
Conversation
The return value of a call is normally a local var, but it can later be promoted to a global var if it is left on the IL stack and then later used in a different basic block. We don't need any special handling if the return value of an async call is a global var.
Member
Author
|
/azp run runtime-libraries-interpreter |
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @BrzVlad, @janvorli, @kg |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the async suspend-data fixup logic in the CoreCLR interpreter compiler to allow the async call return value “var” to be a global (dedicated-offset) variable, removing an assertion that incorrectly assumed it could never be global.
Changes:
- Removes the
assert(!m_pVars[varIndex].global)inInterpCompiler::UpdateLocalIntervalMaps(). - Narrows the “unused async return value” invalidation case to only apply when the return value var is not global and has
liveStart == liveEnd.
jakobbotsch
approved these changes
May 25, 2026
Member
Author
|
/ba-g failures unrelated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The return value of a call is normally a local var, but it can later be promoted to a global var if it is left on the IL stack and then later used in a different basic block. We don't need any special handling if the return value of an async call is a global var.
Assertion incorrectly added in #128403