Skip to content

Bug fixes for Orleans Bank Account sample. #7019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ReubenBond merged 2 commits into from
Jun 9, 2025
Merged

Bug fixes for Orleans Bank Account sample. #7019

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa19cbe
Bug fixes for Orleans Bank Account sample.
Rossimac Feb 21, 2025
7a91f98
Code Review suggestions and bug fixes.
Rossimac Jun 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions orleans/BankAccount/AccountTransfer.Grains/AccountGrain.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,10 @@

namespace AccountTransfer.Grains;

[GenerateSerializer, Immutable]
public record class Balance
[GenerateSerializer]
public class class Balance
{
public int Value { get; init; } = 1_000;
public int Value { get; set; } = 1_000;
}

[Reentrant]
Expand All @@ -21,7 +21,7 @@ public AccountGrain(

public Task Deposit(int amount) =>
_balance.PerformUpdate(
balance => balance with { Value = balance.Value + amount });
balance => balance.Value += amount);

public Task Withdraw(int amount) =>
_balance.PerformUpdate(balance =>
Expand All @@ -34,7 +34,7 @@ public Task Withdraw(int amount) =>
$" This account has {balance.Value} credits.");
}

return balance with { Value = balance.Value + amount };
balance = balance.Value -= amount;
Copy link
Copy Markdown
Member

@ReubenBond ReubenBond May 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The balance = part here is unnecessary - the balance variable goes out of scope immediately after this statement

});

public Task<int> GetBalance() =>
Expand Down