Skip to content

Fix state inconsistency in Orleans Chirper account #7125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TimonPasslick wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −1
Open

Fix state inconsistency in Orleans Chirper account #7125

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion orleans/Chirper/Chirper.Grains/ChirperAccount.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,11 @@
using Microsoft.Extensions.Logging;
using Orleans.Concurrency;
using Orleans.Runtime;
using Orleans.Serialization.Invocation;

namespace Chirper.Grains;

[Reentrant]
[MayInterleave(nameof(WontFollowAndUnfollowSimultaneously))]
public sealed class ChirperAccount : Grain, IChirperAccount
{
/// <summary>
Expand Down Expand Up @@ -48,6 +49,9 @@ public ChirperAccount(
private static string GrainType => nameof(ChirperAccount);
private string GrainKey => this.GetPrimaryKeyString();

public static bool WontFollowAndUnfollowSimultaneously(IInvokable request) =>
request.GetMethodName() is not (nameof(FollowUserIdAsync) or nameof(UnfollowUserIdAsync));

public override Task OnActivateAsync(CancellationToken _)
{
_logger.LogInformation("{GrainType} {GrainKey} activated.", GrainType, GrainKey);
Expand Down