Aggregate and send build/tasks/msbuild-subclassed telemetry in MSBuildLogger#55054
Open
AR-May wants to merge 1 commit into
Open
Aggregate and send build/tasks/msbuild-subclassed telemetry in MSBuildLogger#55054AR-May wants to merge 1 commit into
AR-May wants to merge 1 commit into
Conversation
…dLogger MSBuild's ProjectTelemetry now logs a third aggregated event, build/tasks/msbuild-subclassed, tracking user-authored subclasses of Microsoft-owned tasks. The SDK MSBuildLogger only routed build/tasks/taskfactory and build/tasks through aggregation; the new event fell through to FormatAndSend and was silently dropped. Wire up the new event name so it is aggregated and emitted on build finished, refactoring the per-event send into a shared helper. Extend ItAggregatesEvents to cover the new event. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the .NET SDK MSBuildLogger telemetry aggregation to include MSBuild’s newly introduced aggregated event build/tasks/msbuild-subclassed, ensuring it’s not silently dropped and is emitted on build completion alongside the existing aggregated task events.
Changes:
- Added support for aggregating and emitting
build/tasks/msbuild-subclassedtelemetry on build finished. - Refactored build-finished emission logic to use a shared
SendAggregatedEventhelper for per-event sending/removal. - Extended the existing aggregation unit test to cover the new aggregated event and validate summation behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/dotnet.Tests/CommandTests/MSBuild/GivenMSBuildLogger.cs | Extends aggregation test to include the new msbuild-subclassed aggregated telemetry and validates merged counts. |
| src/Cli/dotnet/Commands/MSBuild/MSBuildLogger.cs | Adds the new aggregated event name, routes it through aggregation, and sends it at build finished via a shared helper. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MSBuild's ProjectTelemetry now logs a third aggregated event,
build/tasks/msbuild-subclassed, tracking user-authored subclasses of Microsoft-owned tasks. The SDKMSBuildLoggeronly routedbuild/tasks/taskfactoryandbuild/tasksthrough aggregation; the new event was silently dropped.Wire up the new event name so it is aggregated and emitted on build finished, refactoring the per-event send into a shared helper.