Skip to content

[release/11.0.1xx-preview6] Containers.targets: (cont) support multi-arch publishing with podman. #55063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
github-actions wants to merge 1 commit into
base: release/11.0.1xx-preview6
Choose a base branch
from
Open

[release/11.0.1xx-preview6] Containers.targets: (cont) support multi-arch publishing with podman. #55063

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions src/Containers/packaging/build/Microsoft.NET.Build.Containers.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,15 +301,10 @@

<Target Name="_PublishMultiArchContainers" DependsOnTargets="$(PublishContainerDependsOn)" Returns="@(GeneratedContainer)" >
<PropertyGroup>
<!--We want to skip publishing individual images in case of multi-arch tarball publishing or local daemon (only docker) publishing because all images are published in one tarball.-->
<!--We want to skip publishing individual images in case of multi-arch tarball publishing or local daemon publishing because all images are published in one tarball.-->
<!--We don't want to skip publishing individual images in case of remote registry because the individual images should be available in the registry before image index is pushed.-->
<!--We don't want to skip publishing individual images in case of local daemon podman because podman loads multi-arch tarball differently - only individual image for the current platform.-->
<_SkipContainerPublishing>false</_SkipContainerPublishing>
<_SkipContainerPublishing Condition="$(ContainerArchiveOutputPath) != '' or ( $(ContainerRegistry) == '' and ( $(LocalRegistry) == '' or $(LocalRegistry) == 'Docker' ) )">true</_SkipContainerPublishing>

<!--We want to skip CreateImageIndex task in case of local daemon podman because it is not supported.-->
<_SkipCreateImageIndex>false</_SkipCreateImageIndex>
<_SkipCreateImageIndex Condition="$(ContainerArchiveOutputPath) == '' and $(ContainerRegistry) == '' and $(LocalRegistry) == 'Podman'">true</_SkipCreateImageIndex>
<_SkipContainerPublishing Condition="$(ContainerArchiveOutputPath) != '' or $(ContainerRegistry) == ''">true</_SkipContainerPublishing>

<!-- Figure out what format the inner images should be coerced to -->
<!-- If a user had an opinion, use that -->
Expand Down Expand Up @@ -354,7 +349,7 @@
<Output TaskParameter="TargetOutputs" ItemName="GeneratedContainer" />
</MSBuild>

<CreateImageIndex Condition="'$(_SkipCreateImageIndex)' == 'false' "
<CreateImageIndex
GeneratedContainers="@(GeneratedContainer)"
LocalRegistry="$(LocalRegistry)"
OutputRegistry="$(ContainerRegistry)"
Expand Down
Loading