Skip to content

bug(Table): not restore scrollbar after close drawer edit form#5780

Merged
ArgoZhang merged 9 commits intomainfrom
refactor-table
Apr 3, 2025
Merged

bug(Table): not restore scrollbar after close drawer edit form#5780
ArgoZhang merged 9 commits intomainfrom
refactor-table

Conversation

@ArgoZhang
Copy link
Copy Markdown
Member

@ArgoZhang ArgoZhang commented Apr 3, 2025

Link issues

fixes #5779

Summary By Copilot

This pull request includes various changes to the Drawer component in the BootstrapBlazor library to improve its functionality and code quality. The most important changes include updating the version, refactoring the backdrop rendering, adding a render control flag, and modifying the JavaScript and SCSS files for better animation handling and styling.

Version Update:

  • Updated the project version to 9.5.3-beta01 in the BootstrapBlazor.csproj file.

Refactoring and Enhancements:

  • Refactored Drawer.razor to use the RenderBackdrop method for rendering the backdrop.
  • Added a _render flag and ShouldRender method to control rendering in Drawer.razor.cs.
  • Added RenderBackdrop method and updated OnContainerClick to manage rendering state in Drawer.razor.cs. [1] [2]

JavaScript and SCSS Modifications:

  • Modified Drawer.razor.js to handle animation frames and backdrop visibility. [1] [2] [3] [4]
  • Updated SCSS for the Drawer component to improve styling and support reduced motion preferences. [1] [2] [3] [4] [5]

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Fix scrollbar restoration and improve drawer component behavior after closing the edit form

Bug Fixes:

  • Resolve issue with scrollbar not being restored after closing the drawer edit form
  • Improve drawer closing animation and backdrop handling

Enhancements:

  • Refactor drawer component to better manage rendering and animation states
  • Add support for reduced motion preferences in drawer animations

Tests:

  • Add unit test for drawer close functionality

@bb-auto bb-auto Bot added the bug Something isn't working label Apr 3, 2025
@bb-auto bb-auto Bot added this to the v9.5.0 milestone Apr 3, 2025
@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai Bot commented Apr 3, 2025

Reviewer's Guide by Sourcery

This pull request includes changes to the Drawer component to improve its functionality and code quality. The changes include updating the version, refactoring the backdrop rendering, adding a render control flag, and modifying the JavaScript and SCSS files for better animation handling and styling. A delay was added when closing the drawer to wait for the animation to complete.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Updated the project version to 9.5.3-beta01.
  • Updated the project version in the BootstrapBlazor.csproj file.
src/BootstrapBlazor/BootstrapBlazor.csproj
Refactored backdrop rendering and added a render control flag to the Drawer component.
  • Refactored Drawer.razor to use the RenderBackdrop method for rendering the backdrop.
  • Added a _render flag and ShouldRender method to control rendering in Drawer.razor.cs.
  • Added RenderBackdrop method and updated OnContainerClick to manage rendering state in Drawer.razor.cs.
src/BootstrapBlazor/Components/Drawer/Drawer.razor
src/BootstrapBlazor/Components/Drawer/Drawer.razor.cs
Modified JavaScript to handle animation frames and backdrop visibility.
  • Modified Drawer.razor.js to handle animation frames.
  • Modified Drawer.razor.js to handle backdrop visibility.
src/BootstrapBlazor/Components/Drawer/Drawer.razor.js
Updated SCSS for the Drawer component to improve styling and support reduced motion preferences.
  • Updated SCSS for the Drawer component to improve styling.
  • Added support for reduced motion preferences to the Drawer component's SCSS.
src/BootstrapBlazor/Components/Drawer/Drawer.razor.scss
Add a delay when closing the drawer if the animation is enabled.
  • Added a delay after setting IsOpen to false to wait for the animation to complete.
src/BootstrapBlazor/Components/Drawer/Drawer.razor.cs

Assessment against linked issues

Issue Objective Addressed Explanation
#5779 Restore the scrollbar after closing the drawer edit form.

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai[bot]
sourcery-ai Bot previously approved these changes Apr 3, 2025
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider extracting the animation delay into a constant for better maintainability.
  • The addition of _render and ShouldRender seem a bit heavy-handed; is there a simpler way to control rendering?
Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟡 Complexity: 1 issue found
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Comment thread src/BootstrapBlazor/Components/Drawer/Drawer.razor.cs
Comment thread src/BootstrapBlazor/Components/Drawer/Drawer.razor.cs
@ArgoZhang ArgoZhang merged commit ae3029f into main Apr 3, 2025
3 checks passed
@ArgoZhang ArgoZhang deleted the refactor-table branch April 3, 2025 08:21
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (eeb045d) to head (94e0449).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #5780   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          658       658           
  Lines        30033     30056   +23     
  Branches      4243      4243           
=========================================
+ Hits         30033     30056   +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(Table): not restore scrollbar after close drawer edit form

1 participant