feat(Slider): update style compatible with row#5797
Merged
Conversation
Contributor
Reviewer's Guide by SourceryThis pull request updates the Slider component's CSS to be compatible with row layouts by modifying the No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- The CSS change looks good, but can you add a comment explaining why the selector was changed?
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5797 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 658 658
Lines 30062 30062
Branches 4244 4244
=========================================
Hits 30062 30062 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #5796
Summary By Copilot
This pull request includes a version update and a modification to the CSS styling in the
Slidercomponent.Version update:
src/BootstrapBlazor/BootstrapBlazor.csproj: Updated the project version from9.5.3to9.5.4.CSS styling modification:
src/BootstrapBlazor/Components/Slider/Slider.razor.scss: Changed the.form-rangeselector to apply styles only to direct children ofdivelements with class names starting with "col-".Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Update Slider component styling to be more compatible with row layouts by refining CSS selector specificity
New Features:
Enhancements: