Conversation
|
Thanks for your PR, @kimdiego2098. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
Contributor
Reviewer's GuideThis PR introduces caching for the GetUniqueName logic by moving its implementation into CacheManager and updating AssemblyExtensions to delegate to the cached method. Sequence diagram for GetUniqueName method with cachingsequenceDiagram
participant Caller
participant AssemblyExtensions
participant CacheManager
participant MemoryCache
Caller->>AssemblyExtensions: GetUniqueName(assembly)
AssemblyExtensions->>CacheManager: GetUniqueName(assembly)
CacheManager->>MemoryCache: GetOrCreate(assembly, ...)
MemoryCache-->>CacheManager: unique name
CacheManager-->>AssemblyExtensions: unique name
AssemblyExtensions-->>Caller: unique name
Class diagram for updated GetUniqueName caching logicclassDiagram
class CacheManager {
+static string GetUniqueName(Assembly assembly)
}
class AssemblyExtensions {
+static string GetUniqueName(Assembly assembly)
}
AssemblyExtensions --> CacheManager: delegates GetUniqueName
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
ArgoZhang
previously approved these changes
Oct 24, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6996 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 741 741
Lines 32365 32371 +6
Branches 4481 4481
=========================================
+ Hits 32365 32371 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ArgoZhang
approved these changes
Oct 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
fixes #6997
feat: GetUniqueName方法添加缓存
Summary by Sourcery
Introduce caching for the GetUniqueName method to avoid repeated computation of assembly names and update the extension method to use the cache.
New Features:
Enhancements: