Skip to content

feat(shadow): add shadow style on invalid form control#7842

Merged
ArgoZhang merged 1 commit intomainfrom
feat-focus
Apr 6, 2026
Merged

feat(shadow): add shadow style on invalid form control#7842
ArgoZhang merged 1 commit intomainfrom
feat-focus

Conversation

@ArgoZhang
Copy link
Copy Markdown
Member

@ArgoZhang ArgoZhang commented Apr 6, 2026

Link issues

fixes #7841

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Enhancements:

  • Suppress box shadow on valid-focused custom-select elements to align with desired success state styling.

Copilot AI review requested due to automatic review settings April 6, 2026 01:39
@bb-auto bb-auto bot added the enhancement New feature or request label Apr 6, 2026
@bb-auto bb-auto bot added this to the v10.5.0 milestone Apr 6, 2026
@ArgoZhang ArgoZhang merged commit bcf0717 into main Apr 6, 2026
5 checks passed
@ArgoZhang ArgoZhang deleted the feat-focus branch April 6, 2026 01:40
@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai bot commented Apr 6, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Ensures valid focused custom select controls do not display a box shadow by explicitly resetting the shadow styling in the validation state.

File-Level Changes

Change Details Files
Adjust focus style for valid custom select controls to remove box shadow.
  • Add box-shadow reset to the :valid:focus and .is-valid:focus states for .custom-select within validated forms
  • Retain existing success border-color styling while preventing any focus shadow from appearing on valid controls
src/BootstrapBlazor/Components/ValidateForm/ValidateForm.razor.scss

Assessment against linked issues

Issue Objective Addressed Explanation
#7841 Add or adjust shadow styling for invalid form controls in the ValidateForm component styles. The PR only adds box-shadow: none; to the .custom-select.is-valid:focus and related valid state selector, which affects the valid (success) state, not the invalid state. No selectors for invalid form controls are modified or added, so the requested shadow style for invalid form controls is not implemented.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates ValidateForm component styling intended to address visual feedback for validation states.

Changes:

  • Normalizes the SCSS @use directive formatting/encoding at the top of the file.
  • Adds box-shadow: none; to the valid (:valid / .is-valid) focus styles for form controls/selects.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 59 to 65
.was-validated .form-control:valid:focus,
.form-control.is-valid:focus,
.was-validated .custom-select:valid:focus,
.custom-select.is-valid:focus {
border-color: var(--bs-success);
box-shadow: none;
}
Copy link

Copilot AI Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change adds box-shadow: none; for the valid focus state, but it doesn't add any shadow styling for the invalid form control state (the invalid focus block above still explicitly sets box-shadow: none;). If the goal is to "add shadow style on invalid form control" (Issue #7841 / PR title), the shadow should be introduced in the :invalid / .is-invalid selectors (e.g., set a danger-tinted box-shadow there) rather than disabling the valid shadow.

Copilot uses AI. Check for mistakes.
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (04cff2b) to head (6a1fd44).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #7842   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          764       764           
  Lines        34165     34165           
  Branches      4704      4704           
=========================================
  Hits         34165     34165           
Flag Coverage Δ
BB 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The PR title and description mention adding shadow styling for invalid controls, but the diff only removes the box-shadow for valid-focused .custom-select; consider clarifying or aligning the implementation with the stated intent.
  • If the goal is to standardize focus styling across controls, you may want to check whether similar :valid:focus rules for other form elements also need box-shadow: none to keep the behavior consistent.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The PR title and description mention adding shadow styling for invalid controls, but the diff only removes the box-shadow for valid-focused `.custom-select`; consider clarifying or aligning the implementation with the stated intent.
- If the goal is to standardize focus styling across controls, you may want to check whether similar `:valid:focus` rules for other form elements also need `box-shadow: none` to keep the behavior consistent.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(shadow): add shadow style on invalid form control

2 participants