Conversation
|
🧙 Sourcery has finished reviewing your pull request! Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Pull request overview
Updates the server demo/project dependency on BootstrapBlazor.DockView to a newer patch version, intended to address the DockViewV2 regression reported in #7853.
Changes:
- Bump
BootstrapBlazor.DockViewNuGet reference from10.0.4to10.0.5.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <PackageReference Include="BootstrapBlazor.Dock" Version="10.0.0" /> | ||
| <PackageReference Include="BootstrapBlazor.DockView" Version="10.0.4" /> | ||
| <PackageReference Include="BootstrapBlazor.DockView" Version="10.0.5" /> | ||
| <PackageReference Include="BootstrapBlazor.Dom2Image" Version="10.0.1" /> |
There was a problem hiding this comment.
The PR claims to fix #7853, but the issue report explicitly states the regression was introduced in DockViewV2 v10.0.5 (working in 10.0.3). This change bumps the dependency to 10.0.5, which appears contradictory—please clarify whether 10.0.5 now contains the fix, or bump to the first version that actually resolves the regression and update the PR/issue accordingly.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7854 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 764 764
Lines 34175 34175
Branches 4705 4705
=========================================
Hits 34175 34175
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #7853
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Build: