Reviewer's Guide

Reverts async disposal and DynamicElement usage introduced previously, simplifying component lifecycles and event handling in DynamicElement, Select, and ButtonBase, and restoring direct HTML elements and callbacks in Select.

Sequence diagram for Select onchange handling after revert

sequenceDiagram
    actor User
    participant Browser
    participant SelectComponent as Select~TValue~

    User->>Browser: Edit text in input
    User->>Browser: Move focus / confirm
    Browser->>SelectComponent: onchange event
    activate SelectComponent
    SelectComponent->>SelectComponent: OnChange(ChangeEventArgs args)
    SelectComponent->>SelectComponent: GetRowsByItems()
    SelectComponent->>SelectComponent: GetItemWithEnumValue()
    SelectComponent->>SelectComponent: GetCurrentSelectItem()
    SelectComponent->>SelectComponent: SelectedItemChanged(SelectedItem item)
    SelectComponent-->>Browser: Render updated selected text
    deactivate SelectComponent

Class diagram for reverted disposal and event handling changes

classDiagram
    class BootstrapComponentBase
    class SimpleSelectBase~TValue~
    class DynamicElement {
    }
    class ButtonBase {
        bool IsAsync
        void RegisterEvents()
        protected ValueTask DisposeAsync(bool disposing)
    }
    class Select~TValue~ {
        string _defaultVirtualizedItemText
        SelectedItem SelectedItem
        SelectedItem SelectedRow
        void OnParametersSet()
        Task OnClickItem(SelectedItem item)
        Task SelectedItemChanged(SelectedItem item)
        Task OnChange(ChangeEventArgs args)
        SelectedItem GetCurrentSelectItem()
    }

    BootstrapComponentBase <|-- DynamicElement
    BootstrapComponentBase <|-- ButtonBase
    SimpleSelectBase~TValue~ <|-- Select~TValue~

    %% Key reverted aspects represented structurally:
    %% - DynamicElement no longer implements IAsyncDisposable
    %% - Select~TValue~ no longer defines a _onChangeEventCallback field
    %% - Select~TValue~ no longer overrides DisposeAsync(bool disposing)
    %% - ButtonBase.DisposeAsync no longer clears click callbacks but still handles async button unregistering

File-Level Changes

Assessment against linked issues

Possibly linked issues

• feat(DynamicElement): add OnTouchStart/End parameter #7897: The PR removes DynamicElement’s IAsyncDisposable implementation and related disposal logic exactly as requested in the issue.

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

@@            Coverage Diff            @@
##              main     #7898   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          764       764           
  Lines        34213     34196   -17     
  Branches      4706      4707    +1     
=========================================
- Hits         34213     34196   -17     

Flags with carried forward coverage won't be shown. Click here to find out more.

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.