refactor(Table): update table layout logic#8009
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideRefines the table CSS class generation so that the 'table-layout-fixed' class is only applied when the table uses a fixed header or column resizing, instead of unconditionally. Flow diagram for conditional table-layout-fixed class applicationflowchart LR
A[BuildTableClassString] --> B{IsFixedHeader or AllowResizing}
B -- true --> C[AddClass table-layout-fixed]
B -- false --> D[Do not add table-layout-fixed]
C --> E[Continue AddClass for other options]
D --> E[Continue AddClass for other options]
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Pull request overview
This PR adjusts the Table component’s CSS class generation to make fixed table layout conditional, aiming to restore backward-compatible table layout behavior.
Changes:
- Applies
table-layout-fixedonly when fixed headers or column resizing are enabled.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| .AddClass("table-bordered", IsBordered) | ||
| .AddClass("table-striped table-hover", IsStriped) | ||
| .AddClass("table-layout-fixed") | ||
| .AddClass("table-layout-fixed", IsFixedHeader || AllowResizing) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8009 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 766 766
Lines 34123 34123
Branches 4691 4692 +1
=========================================
Hits 34123 34123
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #8008
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Bug Fixes: