Skip to content

refactor(Table): update table layout logic#8009

Merged
ArgoZhang merged 1 commit into
mainfrom
refactor-table
May 17, 2026
Merged

refactor(Table): update table layout logic#8009
ArgoZhang merged 1 commit into
mainfrom
refactor-table

Conversation

@ArgoZhang
Copy link
Copy Markdown
Member

@ArgoZhang ArgoZhang commented May 17, 2026

Link issues

fixes #8008

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Bug Fixes:

  • Avoid forcing fixed table layout when neither fixed headers nor column resizing is enabled.

Copilot AI review requested due to automatic review settings May 17, 2026 07:31
@bb-auto bb-auto Bot added the enhancement New feature or request label May 17, 2026
@bb-auto bb-auto Bot added this to the v10.6.0 milestone May 17, 2026
@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai Bot commented May 17, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Refines the table CSS class generation so that the 'table-layout-fixed' class is only applied when the table uses a fixed header or column resizing, instead of unconditionally.

Flow diagram for conditional table-layout-fixed class application

flowchart LR
    A[BuildTableClassString] --> B{IsFixedHeader or AllowResizing}
    B -- true --> C[AddClass table-layout-fixed]
    B -- false --> D[Do not add table-layout-fixed]
    C --> E[Continue AddClass for other options]
    D --> E[Continue AddClass for other options]
Loading

File-Level Changes

Change Details Files
Make application of the 'table-layout-fixed' CSS class conditional based on table configuration.
  • Update the table element CSS builder to only add the 'table-layout-fixed' class when either fixed headers or column resizing are enabled
  • Leave all other table CSS class conditions (Excel, bordered, striped, hover, draggable) unchanged
src/BootstrapBlazor/Components/Table/Table.razor.cs

Assessment against linked issues

Issue Objective Addressed Explanation
#8008 Restore the table layout (table-layout-fixed) setting logic so that it is backward compatible with previous behavior.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@ArgoZhang ArgoZhang merged commit 59f1995 into main May 17, 2026
6 checks passed
@ArgoZhang ArgoZhang deleted the refactor-table branch May 17, 2026 07:31
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts the Table component’s CSS class generation to make fixed table layout conditional, aiming to restore backward-compatible table layout behavior.

Changes:

  • Applies table-layout-fixed only when fixed headers or column resizing are enabled.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

.AddClass("table-bordered", IsBordered)
.AddClass("table-striped table-hover", IsStriped)
.AddClass("table-layout-fixed")
.AddClass("table-layout-fixed", IsFixedHeader || AllowResizing)
@codecov
Copy link
Copy Markdown

codecov Bot commented May 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (6baa850) to head (b8f2f8e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #8009   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          766       766           
  Lines        34123     34123           
  Branches      4691      4692    +1     
=========================================
  Hits         34123     34123           
Flag Coverage Δ
BB 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor(Table): 恢复表格布局设置逻辑向下兼容

2 participants