Skip to content

refactor(Table): add DisplayName parameter event invisible#8011

Merged
ArgoZhang merged 2 commits into
mainfrom
fix-table-display-name
May 17, 2026
Merged

refactor(Table): add DisplayName parameter event invisible#8011
ArgoZhang merged 2 commits into
mainfrom
fix-table-display-name

Conversation

@ArgoZhang
Copy link
Copy Markdown
Member

@ArgoZhang ArgoZhang commented May 17, 2026

Link issues

fixes #8010

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Bug Fixes:

  • Preserve and update display names for invisible table columns instead of restricting display name updates to visible columns only.

Copilot AI review requested due to automatic review settings May 17, 2026 07:38
@bb-auto bb-auto Bot added the enhancement New feature or request label May 17, 2026
@bb-auto bb-auto Bot added this to the v10.6.0 milestone May 17, 2026
@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai Bot commented May 17, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adjusts table column visibility handling so that DisplayName is always updated from the corresponding column definition, even when the column is invisible, while still only caching visible columns.

Flow diagram for updated ResetVisibleColumnsCache visibility and DisplayName handling

flowchart TD
    A[Start ResetVisibleColumnsCache] --> B[Loop over _tableColumnStates]
    B --> C[Get current item]
    C --> D[Find col in Columns by GetFieldName == item.Name]
    D --> E{col != null?}
    E -->|No| F[Next item]
    E -->|Yes| G[Set item.DisplayName = col.GetDisplayName]
    G --> H{item.Visible?}
    H -->|Yes| I[Add col to _visibleColumnsCache]
    H -->|No| F
    I --> F
    F --> J{More items?}
    J -->|Yes| B
    J -->|No| K[End ResetVisibleColumnsCache]
Loading

File-Level Changes

Change Details Files
Ensure table column DisplayName is synchronized from column metadata regardless of visibility, while only visible columns are added to the visible-columns cache.
  • Refactors the visibility loop to first resolve the column definition by matching the field name from the column state list.
  • Updates each column state's DisplayName from the resolved column's GetDisplayName() even when the column is not visible.
  • Limits additions to the _visibleColumnsCache to only those columns where the column state is marked Visible.
src/BootstrapBlazor/Components/Table/Table.razor.Toolbar.cs

Assessment against linked issues

Issue Objective Addressed Explanation
#8010 Ensure that the Table column state always has its DisplayName parameter set, even when the column is invisible, while still only caching visible columns.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • In ResetVisibleColumnsCache, consider inverting the condition to early-continue when col is null (e.g., if (col is null) continue;) so the main logic (updating DisplayName and optionally adding to _visibleColumnsCache) is less nested and easier to follow.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- In `ResetVisibleColumnsCache`, consider inverting the condition to early-continue when `col` is null (e.g., `if (col is null) continue;`) so the main logic (updating `DisplayName` and optionally adding to `_visibleColumnsCache`) is less nested and easier to follow.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses #8010 by ensuring TableColumnState.DisplayName is updated even when a column is currently invisible, so the column list UI can still render correct labels for hidden columns.

Changes:

  • Update ResetVisibleColumnsCache() to set DisplayName for both visible and invisible columns.
  • Keep visible-columns cache behavior the same (only visible columns are added).
  • Bump package version to 10.6.1-beta22.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/BootstrapBlazor/Components/Table/Table.razor.Toolbar.cs Ensures column state DisplayName is refreshed regardless of visibility while maintaining the visible-columns cache.
src/BootstrapBlazor/BootstrapBlazor.csproj Version bump to 10.6.1-beta22.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/BootstrapBlazor/Components/Table/Table.razor.Toolbar.cs
@codecov
Copy link
Copy Markdown

codecov Bot commented May 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (59f1995) to head (628d1b1).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #8011   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          766       766           
  Lines        34123     34123           
  Branches      4692      4692           
=========================================
  Hits         34123     34123           
Flag Coverage Δ
BB 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ArgoZhang ArgoZhang merged commit 38985b7 into main May 17, 2026
10 checks passed
@ArgoZhang ArgoZhang deleted the fix-table-display-name branch May 17, 2026 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor(Table): add DisplayName parameter event invisible

2 participants