Skip to content

refactor(Table): restore AutoFitColumnWidthCallback invoke method#8015

Merged
ArgoZhang merged 2 commits into
mainfrom
refactor-table
May 18, 2026
Merged

refactor(Table): restore AutoFitColumnWidthCallback invoke method#8015
ArgoZhang merged 2 commits into
mainfrom
refactor-table

Conversation

@ArgoZhang
Copy link
Copy Markdown
Member

@ArgoZhang ArgoZhang commented May 18, 2026

Link issues

fixes #8014

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Restore a JavaScript-invokable callback entry point for auto-fitting table column widths while directing callers toward the newer resize callback API.

Bug Fixes:

  • Reintroduce the AutoFitColumnWidthCallback method to maintain compatibility with existing JavaScript code that relies on it.

Enhancements:

  • Mark the restored AutoFitColumnWidthCallback as obsolete and excluded from code coverage, guiding migration to ResizeColumnCallback.

Copilot AI review requested due to automatic review settings May 18, 2026 01:19
@bb-auto bb-auto Bot added the enhancement New feature or request label May 18, 2026
@bb-auto bb-auto Bot added this to the v10.6.0 milestone May 18, 2026
@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai Bot commented May 18, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Restores a JavaScript-invokable, but now obsolete, AutoFitColumnWidthCallback entry point that forwards to the existing ResizeColumnCallback, preserving backward compatibility for external callers without changing the new implementation path.

Sequence diagram for restored AutoFitColumnWidthCallback delegation

sequenceDiagram
    participant JavaScript
    participant Table

    JavaScript->>Table: AutoFitColumnWidthCallback(fieldName, columnState)
    Table->>Table: ResizeColumnCallback(fieldName, columnState)
Loading

File-Level Changes

Change Details Files
Reintroduce a JS-invokable AutoFitColumnWidthCallback method that delegates to the current ResizeColumnCallback to maintain backward compatibility while marking it obsolete and excluding it from code coverage.
  • Add a documented AutoFitColumnWidthCallback method intended to be called from JavaScript for auto-fitting column widths
  • Annotate the method with JSInvokable so existing JavaScript interop can call it
  • Mark the method as Obsolete, directing callers to use ResizeColumnCallback instead
  • Exclude the method from code coverage since it is a compatibility shim
  • Delegate the implementation to ResizeColumnCallback to reuse the existing resize logic
src/BootstrapBlazor/Components/Table/Table.razor.cs

Assessment against linked issues

Issue Objective Addressed Explanation
#8014 Restore the AutoFitColumnWidthCallback JS-invokable method on the Table component so that it can be called (e.g., from JavaScript) again.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Restores the previously removed AutoFitColumnWidthCallback JS-invokable method on Table as an obsolete shim that delegates to the new ResizeColumnCallback, preserving backward compatibility for callers/JS that still reference the old name. Also bumps the package version.

Changes:

  • Re-add AutoFitColumnWidthCallback as a [JSInvokable], [Obsolete], [ExcludeFromCodeCoverage] wrapper calling ResizeColumnCallback.
  • Bump version from 10.6.1-beta23 to 10.6.1-beta24.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/BootstrapBlazor/Components/Table/Table.razor.cs Adds obsolete AutoFitColumnWidthCallback shim delegating to ResizeColumnCallback.
src/BootstrapBlazor/BootstrapBlazor.csproj Version bump to 10.6.1-beta24.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/BootstrapBlazor/Components/Table/Table.razor.cs
@codecov
Copy link
Copy Markdown

codecov Bot commented May 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (ef8f70f) to head (c3252ed).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #8015   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          766       766           
  Lines        34123     34123           
  Branches      4692      4692           
=========================================
  Hits         34123     34123           
Flag Coverage Δ
BB 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ArgoZhang ArgoZhang merged commit 4cdc748 into main May 18, 2026
10 checks passed
@ArgoZhang ArgoZhang deleted the refactor-table branch May 18, 2026 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor(Table): restore AutoFitColumnWidthCallback invoke method

2 participants