improved discovery

Author: mzorec

src/FlubuCore.Tests/FlubuCore.Tests.csproj

@@ -81,7 +81,7 @@
     <ProjectReference Include="..\FlubuCore\FlubuCore.csproj" />
   </ItemGroup>
   <ItemGroup>
-<PackageReference Include="Microsoft.Extensions.Logging.Console" Version="8.0.0" />
+    <PackageReference Include="Microsoft.Extensions.Logging.Console" Version="8.0.0" />
     <PackageReference Include="StyleCop.Analyzers" Version="1.1.118">
       <PrivateAssets>All</PrivateAssets>
     </PackageReference>

src/FlubuCore/Commanding/CommandExecutor.cs

@@ -51,7 +51,7 @@ public virtual async Task<int> ExecuteAsync()
                 {
                     script = await _scriptProvider.GetBuildScriptAsync(Args);
                 }
-                catch
+                catch (Exception)
                 {
                     // Continue without script — completions will only include built-in options
                 }

src/FlubuCore/Commanding/ShellCompletionProvider.cs

@@ -86,15 +86,14 @@ public IReadOnlyList<string> GetCompletions(
             var tokens = TokenizeCommandLine(partialCommandLine);
             var wordToComplete = GetWordToComplete(partialCommandLine, tokens);
 
-            var targetNames = DiscoverTargets(flubuSession, script, targetCreator);
-            var scriptArgs = DiscoverScriptArgs(script, scriptProperties);
-
             if (wordToComplete.StartsWith("-"))
             {
+                var scriptArgs = DiscoverScriptArgs(script, scriptProperties);
                 var candidates = BuiltInOptions.Concat(scriptArgs).ToList();
                 return FilterCandidates(candidates, wordToComplete);
             }
 
+            var targetNames = DiscoverTargets(flubuSession, script, targetCreator);
             var targetCandidates = targetNames.Concat(BuiltInCommands).ToList();
             return FilterCandidates(targetCandidates, wordToComplete);
         }
@@ -122,7 +121,7 @@ private static List<string> DiscoverTargets(
 
                 return flubuSession.TargetTree.GetTargetNames().ToList();
             }
-            catch
+            catch (Exception)
             {
                 return new List<string>();
             }
@@ -143,7 +142,7 @@ private static List<string> DiscoverScriptArgs(
                     .Select(h => h.Name)
                     .ToList();
             }
-            catch
+            catch (Exception)
             {
                 return new List<string>();
             }