Commit f01330d
committed
fix(ci): resolve eslint errors blocking master builds
CI was failing on every push since the search palette + article-toc updates.
The Next build was passing locally but the CI's stricter eslint catches more.
2 errors fixed:
- command-palette.tsx:40 + :64 — setState() inside useEffect bodies.
Both intentional reset patterns (open → reset query/selection,
query change → reset selected index). Same situation we hit earlier
with the save-button + audit-client. Resolved with eslint-disable
comments + reason notes ("intentional reset when modal opens" /
"intentional reset when query changes"). Will refactor to
useSyncExternalStore-pattern later if needed.
3 warnings fixed:
- page.tsx — 'categories' destructured but unused, removed
- vs-tools/page.tsx — 'LIST_PROBLEMS' imported but unused, removed
- article-toc.tsx — useEffect with 'allIds.join(",")' as a complex
dep expression. Refactored: useMemo for the joined ids string,
use it as the single dep. Cleaner + lint-rule-compliant.1 parent e5a58a3 commit f01330d
4 files changed
Lines changed: 15 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | | - | |
| 10 | + | |
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
8 | | - | |
9 | 8 | | |
10 | 9 | | |
11 | 10 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
| 3 | + | |
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
14 | | - | |
15 | | - | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
16 | 20 | | |
17 | 21 | | |
18 | | - | |
| 22 | + | |
| 23 | + | |
19 | 24 | | |
20 | | - | |
| 25 | + | |
21 | 26 | | |
22 | 27 | | |
23 | 28 | | |
| |||
40 | 45 | | |
41 | 46 | | |
42 | 47 | | |
43 | | - | |
| 48 | + | |
44 | 49 | | |
45 | 50 | | |
46 | 51 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
37 | 37 | | |
38 | 38 | | |
39 | 39 | | |
| 40 | + | |
40 | 41 | | |
41 | 42 | | |
| 43 | + | |
42 | 44 | | |
43 | 45 | | |
44 | 46 | | |
| |||
61 | 63 | | |
62 | 64 | | |
63 | 65 | | |
| 66 | + | |
64 | 67 | | |
65 | 68 | | |
66 | 69 | | |
| |||
0 commit comments