fix: emit labels-changed from save() so Web UI edits reach HA Discovery

User reported: editing labels in the Web UI and clicking Save did NOT
update device names in Home Assistant. Root cause traced to LabelLoader:

- save() wrote the file + updated internal state, but never emitted
  labels-changed
- The only emit site was _onFileChanged (the fs.watch callback) at
  labelLoader.js:315
- The watcher correctly suppresses its own callback for SELF_WRITE_GRACE_MS
  (1000ms) after each save() to prevent re-processing our own write
  (labelLoader.js:184)
- Net effect: for in-process saves (PUT /api/labels, PATCH /api/labels,
  POST /api/labels/import) the event was silently swallowed
- The bridgeInitializationService listener that calls
  haDiscovery.updateLabels + trigger() therefore never ran, and HA never
  saw the updated discovery configs

save() now emits labels-changed directly with the full getLabelData()
payload. The watcher's grace period is still correct - it prevents the
file-event path from double-firing.

Same fix automatically covers areas, type_overrides, entity_ids, and
exclude - they all flow through the single save() codepath, and
getLabelData() includes all five sections.

Audit of other label-lifecycle paths found no further bugs: only one
labels-changed subscriber (the bridge), only two emit sites (save and
the watcher callback), no other code paths mutate internal Maps without
going through save() or _onFileChanged.

Tests: new regression for save()-emits-once, new test confirming areas
and the other sections are in the emit payload. The pre-existing
"should not emit when file is written by save() within grace period"
test was codifying the bug; rewritten to assert exactly-once instead.
1256/1256 pass.

Author: dougrathbone

homeassistant-addon/CHANGELOG.md

@@ -5,6 +5,14 @@ All notable changes to the C-Gate Web Bridge Home Assistant add-on will be docum
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [1.9.3] - 2026-05-27
+
+### Fixed
+
+- **Editing labels (or areas / type overrides / entity IDs / exclusions) via the Web UI did not update Home Assistant device names**. `LabelLoader.save()` wrote the file and updated internal state but never emitted `labels-changed` directly. The only emit site was the `fs.watch` callback, which is gated by a 1000ms self-write grace period to prevent double-processing - so for in-process saves (PUT/PATCH `/api/labels`, POST `/api/labels/import`), the event was silently suppressed. The downstream listener that re-triggers HA Discovery therefore never fired, and HA never saw the updated entity configs.
+  - `save()` now emits `labels-changed` directly with the full `getLabelData()` payload (labels, areas, typeOverrides, entityIds, exclude). The file-watcher path still correctly suppresses the resulting fs event within the grace window, so there's no double-fire.
+  - The same fix automatically covers areas, type overrides, entity IDs, and the exclude list - all flow through the single `save()` codepath.
+
 ## [1.9.2] - 2026-05-26
 
 ### Changed

homeassistant-addon/config.yaml

@@ -1,5 +1,5 @@
 name: "C-Gate Web Bridge"
-version: "1.9.2"
+version: "1.9.3"
 slug: cgateweb
 description: "Bridge between Clipsal C-Bus systems and MQTT/Home Assistant"
 url: "https://github.com/dougrathbone/cgateweb"

package.json

@@ -1,6 +1,6 @@
 {
   "name": "cgateweb",
-  "version": "1.9.2",
+  "version": "1.9.3",
   "description": "Node.js bridge connecting Clipsal C-Bus automation systems to MQTT for Home Assistant integration",
   "keywords": [
     "cbus",

src/labelLoader.js

@@ -159,6 +159,12 @@ class LabelLoader extends EventEmitter {
         }
 
         this.logger.info(`Saved ${this._labels.size} labels to ${this.filePath}`);
+
+        // Notify in-process listeners (HA Discovery re-trigger, the Web UI
+        // SSE event stream) directly. The file-watcher path will see the
+        // same write but suppress it via SELF_WRITE_GRACE_MS - that grace
+        // period prevents a double-fire here, it doesn't replace this emit.
+        this.emit('labels-changed', this.getLabelData());
     }
 
     /**

tests/labelLoader.test.js

@@ -122,6 +122,53 @@ describe('LabelLoader', () => {
             const loader = new LabelLoader(null);
             expect(() => loader.save({})).toThrow('No label file path configured');
         });
+
+        it('emits labels-changed synchronously after save so in-process callers (web UI) trigger HA Discovery refresh', () => {
+            // Regression for the bug where editing labels via the Web UI did
+            // NOT update Home Assistant device names. save() wrote the file
+            // and updated internal state but never emitted labels-changed -
+            // the watcher's self-write grace period then suppressed the
+            // file-event-driven emit, so the bridge's HA Discovery
+            // re-trigger listener never fired.
+            const loader = new LabelLoader(labelFile);
+            const events = [];
+            loader.on('labels-changed', (labelData) => events.push(labelData));
+
+            loader.save({ '254/56/10': 'Kitchen Bench', '254/56/11': 'Hallway' });
+
+            expect(events.length).toBe(1);
+            expect(events[0].labels.get('254/56/10')).toBe('Kitchen Bench');
+            expect(events[0].labels.get('254/56/11')).toBe('Hallway');
+        });
+
+        it('labels-changed payload carries areas / type_overrides / entity_ids / exclude in addition to labels', () => {
+            // The bridge's listener pipes getLabelData() into HaDiscovery.updateLabels,
+            // which consumes all five sections. If save() ever stops including any of
+            // them in the emit payload, HA entity area assignments / type overrides /
+            // explicit unique-id-suffixes / exclusion lists silently stop applying on
+            // edit. Lock the full contract here.
+            const loader = new LabelLoader(labelFile);
+            const events = [];
+            loader.on('labels-changed', (labelData) => events.push(labelData));
+
+            loader.save({
+                version: 1,
+                labels: { '254/56/10': 'Kitchen' },
+                type_overrides: { '254/203/15': 'cover' },
+                entity_ids: { '254/56/10': 'kitchen_main' },
+                exclude: ['254/56/250'],
+                areas: { '254/56/10': 'Kitchen', '254/56/11': 'Hallway' }
+            });
+
+            expect(events.length).toBe(1);
+            const payload = events[0];
+            expect(payload.labels.get('254/56/10')).toBe('Kitchen');
+            expect(payload.typeOverrides.get('254/203/15')).toBe('cover');
+            expect(payload.entityIds.get('254/56/10')).toBe('kitchen_main');
+            expect(payload.exclude.has('254/56/250')).toBe(true);
+            expect(payload.areas.get('254/56/10')).toBe('Kitchen');
+            expect(payload.areas.get('254/56/11')).toBe('Hallway');
+        });
     });
 
     describe('getLabelsObject', () => {
@@ -390,7 +437,11 @@ describe('LabelLoader', () => {
             }, 100);
         }, 5000);
 
-        it('should not emit when file is written by save() within grace period', (done) => {
+        it('save() emits labels-changed exactly once even with the watcher running (no double-fire)', (done) => {
+            // The watcher's SELF_WRITE_GRACE_MS exists to prevent a SECOND
+            // labels-changed firing from the fs.watch callback after our own
+            // write. The FIRST emit comes from save() directly so the in-
+            // process listeners (HA Discovery refresh, web UI SSE) wake up.
             const data = { version: 1, labels: { '254/56/10': 'Init' } };
             fs.writeFileSync(labelFile, JSON.stringify(data));
 
@@ -401,16 +452,17 @@ describe('LabelLoader', () => {
             const handler = jest.fn();
             loader.on('labels-changed', handler);
 
-            // save() sets _lastSaveTime; fs.watch events within 1s grace are suppressed
             loader.save({ '254/56/10': 'Via Save' });
 
-            // Wait longer than debounce (500ms) but within the grace period (1000ms)
+            // Wait longer than debounce (500ms) and longer than grace (1000ms)
+            // to confirm only the direct emit fired, not the file-watcher path.
             setTimeout(() => {
-                expect(handler).not.toHaveBeenCalled();
+                expect(handler).toHaveBeenCalledTimes(1);
+                expect(handler.mock.calls[0][0].labels.get('254/56/10')).toBe('Via Save');
                 loader.unwatch();
                 done();
-            }, 800);
-        }, 3000);
+            }, 1500);
+        }, 5000);
 
         it('should do nothing when no file path is configured', () => {
             const loader = new LabelLoader(null);