docs: fix docs dark mode example contrast#1694
Conversation
|
hey @pupuking723 thanks for the PR! I will take a look shortly. One comment: the original issue is about the styles in the downshift docsite, which sits in this repo. If you would also like to take a shot at that, it would be great! Thanks! |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1694 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 18 69 +51
Lines 1726 1922 +196
Branches 518 591 +73
==========================================
+ Hits 1726 1922 +196 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Thanks for reviewing and merging this. I’ll take a look at the docsite styling location as a follow-up and open a separate PR if I can keep it scoped. |
Fixes #1668.
This updates the Docusaurus example controls to use theme-aware colors instead of hard-coded light mode values. The shared examples now use Docusaurus color variables for labels, inputs, buttons, select toggles, and menu text, with explicit highlighted-item colors for dark mode. The tag group combobox styles also use theme variables for the input wrapper, input, toggle button, menu, and highlighted options.
The change is scoped to documentation examples only and does not touch Downshift runtime behavior.
Verification: