Skip to content

Commit 17bc449

Browse files
authored
Do not skip pressure solver step for the rotation tests (#95)
Skipping the pressure solver step can cause numerical dissipation due to the projection error. Removing the null-setting codes and let tests run with normal version of the solvers. This fixes issue #94.
1 parent bf83fdb commit 17bc449

3 files changed

Lines changed: 0 additions & 3 deletions

File tree

src/tests/manual_tests/apic_solver2_tests.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,6 @@ JET_BEGIN_TEST_F(ApicSolver2, Rotation) {
5353
.makeShared();
5454

5555
solver->setGravity({0, 0});
56-
solver->setPressureSolver(nullptr);
5756

5857
// Build emitter
5958
auto box =

src/tests/manual_tests/flip_solver2_tests.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,6 @@ JET_BEGIN_TEST_F(FlipSolver2, Rotation) {
5353
.makeShared();
5454

5555
solver->setGravity({0, 0});
56-
solver->setPressureSolver(nullptr);
5756

5857
// Build emitter
5958
auto box = Sphere2::builder()

src/tests/manual_tests/pic_solver2_tests.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,6 @@ JET_BEGIN_TEST_F(PicSolver2, Rotation) {
5353
.makeShared();
5454

5555
solver->setGravity({0, 0});
56-
solver->setPressureSolver(nullptr);
5756

5857
// Build emitter
5958
auto box = Sphere2::builder()

0 commit comments

Comments
 (0)