Skip to content

Commit ce3990a

Browse files
authored
Minor typo/error fixes (#88)
* Fix typos in BoundingBox doc * Initialize _maxNumberOfParticles to kMaxSize
1 parent ab96279 commit ce3990a

4 files changed

Lines changed: 5 additions & 5 deletions

File tree

include/jet/bounding_box2.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ class BoundingBox<T, 2> {
9595
//! Merges this and other point.
9696
void merge(const Vector2<T>& point);
9797

98-
//! Merges this and other boxes.
98+
//! Merges this and other box.
9999
void merge(const BoundingBox& other);
100100

101101
//! Expands this box by given delta to all direction.

include/jet/bounding_box3.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ struct BoundingBoxRayIntersection3 {
4040
template <typename T>
4141
class BoundingBox<T, 3> {
4242
public:
43-
//! Upper corner of the bounding box.
43+
//! Lower corner of the bounding box.
4444
Vector3<T> lowerCorner;
4545

4646
//! Upper corner of the bounding box.
@@ -98,7 +98,7 @@ class BoundingBox<T, 3> {
9898
//! Merges this and other point.
9999
void merge(const Vector3<T>& point);
100100

101-
//! Merges this and other boxes.
101+
//! Merges this and other box.
102102
void merge(const BoundingBox& other);
103103

104104
//! Expands this box by given delta to all direction.

include/jet/volume_particle_emitter2.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ class VolumeParticleEmitter2 final : public ParticleEmitter2 {
129129
Vector2D _initialVel;
130130
PointGenerator2Ptr _pointsGen;
131131

132-
size_t _maxNumberOfParticles;
132+
size_t _maxNumberOfParticles = kMaxSize;
133133
size_t _numberOfEmittedParticles = 0;
134134

135135
double _jitter = 0.0;

include/jet/volume_particle_emitter3.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ class VolumeParticleEmitter3 final : public ParticleEmitter3 {
128128
Vector3D _initialVel;
129129
PointGenerator3Ptr _pointsGen;
130130

131-
size_t _maxNumberOfParticles = std::numeric_limits<size_t>::max();
131+
size_t _maxNumberOfParticles = kMaxSize;
132132
size_t _numberOfEmittedParticles = 0;
133133

134134
double _jitter = 0.0;

0 commit comments

Comments
 (0)