[SD-1738] add external site link content type#779
Open
lambry wants to merge 12 commits into
Open
Conversation
… message and node path
lambry
requested review from
anthony-malkoun,
dylankelly,
vincent-gao and
waitingallday
|
@waitingallday, @dylankelly, @anthony-malkoun, @vincent-gao |
vincent-gao
requested changes
Jun 9, 2026
vincent-gao
left a comment
vincent-gao
left a comment
Contributor
There was a problem hiding this comment.
hey @lambry , I have 2 questions.
vincent-gao
approved these changes
Jun 12, 2026
Contributor
|
oh @lambry the build gets failed. |
vincent-gao
requested changes
Jun 12, 2026
vincent-gao
left a comment
vincent-gao
left a comment
Contributor
There was a problem hiding this comment.
oh, sorry @lambry , there is a test gets failed. could you please take a look.
Contributor
Author
Hmm, seems like all PRs are failing now, I re-ran the build on #783 without changes and it's failing now too. Other PRs like #781 are failing with the same issue as well https://github.com/dpc-sdp/tide_core/actions/runs/27249872911/job/80471778340?pr=781#step:10:958 CC @vincent-gao |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA issue: https://digital-vic.atlassian.net/browse/SD-1738
Changed
@vincent-gao let me know if there's parts of this that can be done in better ways, cheers.
REF:
https://nginx-php.pr-1984.content-vic.sdp4.sdp.vic.gov.au/
https://nginx-php.pr-47.howqua.sdp4.sdp.vic.gov.au/
Also note the PR branches above have some code for placing the content type in the correct alphabetic location in the main menu.
https://github.com/dpc-sdp/content-vic-gov-au/pull/1984
https://github.com/dpc-sdp/howqua/pull/47
Screenshots