fix(io): make the Xenium QV threshold configurable (default 20)#55
Open
EliHei2 wants to merge 1 commit into
Open
fix(io): make the Xenium QV threshold configurable (default 20)#55EliHei2 wants to merge 1 commit into
EliHei2 wants to merge 1 commit into
Conversation
The Xenium reader hard-coded `.filter(qv >= 20)`. Promote it to a `min_qv` preprocessor parameter (threaded through get_preprocessor) with a per-platform DEFAULT_MIN_QV (20.0 for Xenium, None elsewhere). Default reproduces today's behaviour exactly; callers can now relax/tighten or disable the QV filter. Review: ISTPreprocessor.__init__ + get_preprocessor signature; the one Xenium filter line now reads self.min_qv.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Xenium reader hard-coded
.filter(qv >= 20). Promote it to amin_qvpreprocessor parameter (threaded through get_preprocessor) with a per-platform DEFAULT_MIN_QV (20.0 for Xenium, None elsewhere). Default reproduces today's behaviour exactly; callers can now relax/tighten or disable the QV filter.Review: ISTPreprocessor.init + get_preprocessor signature; the one Xenium filter line now reads self.min_qv.