fix(writer): guard per-gene thresholding against degenerate similarities#59
Open
EliHei2 wants to merge 1 commit into
Open
fix(writer): guard per-gene thresholding against degenerate similarities#59EliHei2 wants to merge 1 commit into
EliHei2 wants to merge 1 commit into
Conversation
threshold_yen / threshold_li_custom crash (or return garbage) on degenerate per-gene similarity arrays. Before thresholding, drop null / non-finite values and short-circuit the two degenerate cases: no finite values -> treat as failed-to-converge (backfilled with the global quantile); a single or constant value -> use that value directly. Prevents crashes on sparse genes. What to review: the few guard lines added before the existing try/except in the per-gene threshold loop. No change for genes with a normal spread of values.
Collaborator
|
I wasn't aware that segger similarities could be Also, when |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
threshold_yen / threshold_li_custom crash (or return garbage) on degenerate per-gene similarity arrays. Before thresholding, drop null / non-finite values and short-circuit the two degenerate cases: no finite values -> treat as failed-to-converge (backfilled with the global quantile); a single or constant value -> use that value directly. Prevents crashes on sparse genes.
What to review: the few guard lines added before the existing try/except in the per-gene threshold loop. No change for genes with a normal spread of values.