[lora] enable bias support for fused moe lora#1583
Merged
Conversation
Signed-off-by: AlpinDale <alpindale@gmail.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request enables bias support for fused MoE with LoRA and corrects the handling of tensor parallelism. The changes involve refactoring how quantization configuration is handled to include bias information, and removing a check that previously prevented bias usage. Additionally, the code is updated to use the number of local experts instead of global experts when creating and applying LoRA weights, which is a critical fix for distributed tensor-parallel execution. The changes are consistent and improve correctness and functionality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.