Skip to content

[python3.10] import Self from typing_extensions #1592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlpinDale merged 1 commit into from
Nov 4, 2025
Merged

[python3.10] import Self from typing_extensions #1592

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion aphrodite/config/structured_outputs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
import hashlib
from typing import Any, Literal, Self
from typing import Any, Literal

from pydantic import model_validator
from pydantic.dataclasses import dataclass
from typing_extensions import Self
Comment on lines 1 to +6

@gemini-code-assist gemini-code-assist Bot Nov 4, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

For better compatibility and future-proofing, it's recommended to use a conditional import for Self based on the Python version. This ensures that the native typing.Self is used on Python 3.11+ while falling back to typing_extensions on older versions. This avoids an unnecessary dependency on typing_extensions for this feature on newer Python versions and makes the code's intent clearer.

Suggested change
import hashlib
from typing import Any, Literal, Self
from typing import Any, Literal
from pydantic import model_validator
from pydantic.dataclasses import dataclass
from typing_extensions import Self
import hashlib
import sys
from typing import Any, Literal
from pydantic import model_validator
from pydantic.dataclasses import dataclass
if sys.version_info < (3, 11):
from typing_extensions import Self
else:
from typing import Self


from aphrodite.config.utils import config

Expand Down