Skip to content

[sync] sync to upstream 03c4c4a#1597

Merged
AlpinDale merged 1 commit into
mainfrom
sync-03c4c4a
Nov 4, 2025
Merged

[sync] sync to upstream 03c4c4a#1597
AlpinDale merged 1 commit into
mainfrom
sync-03c4c4a

Conversation

@AlpinDale
Copy link
Copy Markdown
Collaborator

No description provided.

Signed-off-by: AlpinDale <alpindale@gmail.com>
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a wide range of features, refactorings, and bug fixes. Key additions include support for Suffix Decoding, prefix caching for Mamba models, and ORCA endpoint load metrics. There are also significant refactorings, such as lazy loading for tool parsers and updates to the KV cache connector factory for better backward compatibility. I've identified one issue related to a configuration default in the Mamba model configuration where a comment and the code are inconsistent, which could be misleading.

Comment thread aphrodite/config/model.py
Comment on lines +1410 to +1413
# Since Mamba1 does not have a chunk notion
# we use a default chunk size of 1024.
if chunk_size is None:
chunk_size = 2048
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

There is a discrepancy between the comment and the code. The comment states that the default chunk size is 1024, but the code sets it to 2048. This can be misleading for developers. Please update the comment to match the code for consistency.

Suggested change
# Since Mamba1 does not have a chunk notion
# we use a default chunk size of 1024.
if chunk_size is None:
chunk_size = 2048
# we use a default chunk size of 2048.
if chunk_size is None:
chunk_size = 2048

@AlpinDale AlpinDale merged commit 5495210 into main Nov 4, 2025
1 check passed
@AlpinDale AlpinDale deleted the sync-03c4c4a branch November 4, 2025 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant