fix: normalize nested args in DeepSeek DSML#1654
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 01186010ee
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if set(converted.keys()) != {"arguments"}: | ||
| return converted |
There was a problem hiding this comment.
arguments parameter key
Do not unwrap every single-key {"arguments": ...} payload here: this helper now strips the arguments key for any tool that legitimately defines one top-level parameter named arguments (for example, properties.arguments in user-provided tool schemas). Because _convert_params_with_schema() calls this in both streaming and non-streaming extraction paths, those tools will receive function.arguments with the wrong shape ({...} instead of {"arguments": {...}}), which breaks downstream argument binding.
Useful? React with 👍 / 👎.
1 participant
DeepSeek-V4 Flash can leak tool call tags.