Skip to content

Commit e1c7f2b

Browse files
committed
Slight gssapi init refactor to make mock easier
1 parent 48dd596 commit e1c7f2b

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

kafka/sasl/gssapi.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,14 +26,15 @@ def __init__(self, **config):
2626
raise ValueError('sasl_kerberos_service_name or sasl_kerberos_name required for GSSAPI sasl configuration')
2727
self._is_done = False
2828
self._is_authenticated = False
29+
self.gssapi_name = None
2930
if config.get('sasl_kerberos_name', None) is not None:
3031
self.auth_id = str(config['sasl_kerberos_name'])
32+
if isinstance(config['sasl_kerberos_name'], gssapi.Name):
33+
self.gssapi_name = config['sasl_kerberos_name']
3134
else:
3235
kerberos_domain_name = config.get('sasl_kerberos_domain_name', '') or config.get('host', '')
3336
self.auth_id = config['sasl_kerberos_service_name'] + '@' + kerberos_domain_name
34-
if isinstance(config.get('sasl_kerberos_name', None), gssapi.Name):
35-
self.gssapi_name = config['sasl_kerberos_name']
36-
else:
37+
if self.gssapi_name is None:
3738
self.gssapi_name = gssapi.Name(self.auth_id, name_type=gssapi.NameType.hostbased_service).canonicalize(gssapi.MechType.kerberos)
3839
self._client_ctx = gssapi.SecurityContext(name=self.gssapi_name, usage='initiate')
3940
self._next_token = self._client_ctx.step(None)

0 commit comments

Comments
 (0)