Fix TaggedFields value encoding; add test coverage#2725
Merged
Conversation
dpkp
added a commit
that referenced
this pull request
Apr 9, 2026
dpkp
added a commit
that referenced
this pull request
Apr 9, 2026
|
@dpkp We were talking about this in an aiokafka PR and it is supposed to be encoded in order according the KIP (not sure why though) aio-libs/aiokafka#1139 (review) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TaggedFields is mostly unused in the current client code, so it makes sense that this bug slipped through. Fixing and adding test coverage. Specifically not testing tag order because I do not think that is part of the protocol spec (tags can be encoded in any order).