eslint fixes

Author: tobimadehin

.github/workflows/lint.yml

@@ -40,4 +40,4 @@ jobs:
         run: vendor/bin/pint --test
 
       - name: Lint Frontend
-        run: pnpm run format:check
+        run: pnpm run format:check && pnpm run lint

composer.json

@@ -66,6 +66,9 @@
             "@php artisan test"
         ],
         "lint": [
+            "vendor/bin/pint"
+        ],
+        "lint:check": [
             "vendor/bin/pint --test"
         ],
         "sync": [

resources/js/components/blueprint.tsx

@@ -11,7 +11,7 @@ interface Props {
     handleBlueprintCopy: () => void;
 }
 
-export function Blueprint({ name, yamlConfig, jsonConfig, blueprintFormat, setBlueprintFormat, handleBlueprintCopy }: Props) {
+export function Blueprint({ yamlConfig, jsonConfig, blueprintFormat, setBlueprintFormat, handleBlueprintCopy }: Props) {
     return (
         <>
             <div className="mb-4 flex items-center justify-between">

resources/js/components/create-service/create-service-page-1.tsx

@@ -25,7 +25,7 @@ interface Props {
     runCmdError: string;
     source: ServiceSource;
     processing: boolean;
-    errors: any;
+    errors: Record<string, string>;
     runCmdPlaceholder?: string;
 
     // Unified handlers

resources/js/components/create-service/create-service-page-2.tsx

@@ -13,7 +13,7 @@ interface Props {
     dnsProvider: string;
     dnsProviderError: string;
     processing: boolean;
-    errors: any;
+    errors: Record<string, string>;
     setField: (field: string, value: any) => void;
 }
 

resources/js/components/image-add-dialog.tsx

@@ -13,13 +13,11 @@ interface Props {
 
 export default function ImageAddDialog({ open, setOpen }: Props) {
     const {
-        branches,
         searchComplete,
         validationError,
         remoteRepo,
         selectedBranch,
         setRemoteRepo,
-        setSelectedBranch,
         getFormAction,
         getFormData,
         handleFormSuccess,

resources/js/hooks/use-deployments.ts

@@ -1,4 +1,5 @@
 import { useRemotes } from '@/hooks/use-remotes';
+import { toast } from '@/lib/toast';
 import type { Blueprint, Service } from '@/types';
 import { useQuery } from '@tanstack/react-query';
 import axios from 'axios';
@@ -16,13 +17,14 @@ export function useDeployments() {
                     params: Object.fromEntries(params),
                 });
                 return response.data;
-            } catch (error) {}
+            } catch (error) {
+                console.error((error as Error).message || "An unknown error occoured while retrieving deployments")
+            }
         },
         staleTime: 5 * 60 * 1000,
     });
 
     const { remotes } = useRemotes();
-    const remotesData = remotes || [];
     const [currentPage, setCurrentPage] = useState(1);
     const itemsPerPage = 8;
     const totalPages = Math.ceil((deployments?.length ?? 0) / itemsPerPage);
@@ -38,11 +40,11 @@ export function useDeployments() {
                 const remote = (config as Partial<Service>)?.remote;
                 let resolvedRemote = remote;
                 if (remote) {
-                    resolvedRemote = remotesData.find((r) => r) || remote;
+                    resolvedRemote = remotes.find((r) => r) || remote;
                 }
                 return { ...deployment, config: { ...config, remote: resolvedRemote } };
             }),
-        [paginatedDeployments, remotesData],
+        [paginatedDeployments, remotes],
     );
 
     const goToPage = (page: number) => {

resources/js/hooks/use-images.ts

@@ -14,7 +14,7 @@ export function useImages(setOpen?: (open: boolean) => void) {
         image_registry: z
             .string()
             .min(1, 'Domain is required')
-            .regex(/^(https?:\/\/)?([\da-z\.-]+)\.([a-z\.]{2,6})([\/\w \.-]*)*\/?$/, 'Please enter a valid docker image registry'),
+            .regex(/^(https?:\/\/)?([\da-z.-]+)\.([a-z.]{2,6})([\/\w .-]*)*\/?$/, 'Please enter a valid docker image registry'),
         branch: z.string().optional(),
     });
 

resources/js/hooks/use-remotes.ts

@@ -17,7 +17,7 @@ export function useRemotes(setOpen?: (open: boolean) => void) {
             remote_repo: z
                 .string()
                 .min(1, 'Domain is required')
-                .regex(/^(https?:\/\/)?([\da-z\.-]+)\.([a-z\.]{2,6})([\/\w \.-]*)*\/?$/, 'Please enter a valid remote address'),
+                .regex(/^(https?:\/\/)?([\da-z.-]+)\.([a-z.]{2,6})([\/\w .-]*)*\/?$/, 'Please enter a valid remote address'),
             branch: z.string().optional(),
         })
         .refine((data) => {
@@ -64,14 +64,6 @@ export function useRemotes(setOpen?: (open: boolean) => void) {
         }
     };
 
-    const reset = () => {
-        setRemoteRepo('');
-        setSelectedBranch('');
-        setBranches([]);
-        setSearchComplete(false);
-        setError('');
-    };
-
     const { data, isLoading } = useQuery<Remote[]>({
         queryKey: ['remotes'],
         queryFn: async () => {
@@ -83,7 +75,7 @@ export function useRemotes(setOpen?: (open: boolean) => void) {
 
     return {
         // State
-        remotes: data,
+        remotes: data || [],
         isLoading,
         branches,
         searchComplete,

resources/js/hooks/use-service-form.ts

@@ -36,7 +36,7 @@ interface ServiceFormState {
 
 type ServiceFormAction =
     | { type: 'SET_CURRENT_PAGE'; payload: number }
-    | { type: 'SET_FIELD'; payload: { field: string; value: any } }
+    | { type: 'SET_FIELD'; payload: { field: string; value: unknown } }
     | { type: 'SET_ERROR'; payload: { field: string; value: string } }
     | { type: 'CLEAR_ALL_ERRORS' }
     | { type: 'NEXT_PAGE' }
@@ -139,7 +139,7 @@ function serviceFormReducer(state: ServiceFormState, action: ServiceFormAction):
     }
 }
 
-export function useServiceForm(onCreateServiceCallback?: () => void | null) {
+export function useServiceForm() {
     const [state, dispatch] = useReducer(serviceFormReducer, initialState);
     const [blueprintFormat, setBlueprintFormat] = useState<BlueprintFormat>('yaml');
 
@@ -311,7 +311,7 @@ export function useServiceForm(onCreateServiceCallback?: () => void | null) {
         dispatch({ type: 'SKIP_TO_CONFIRMATION' });
     };
 
-    const setField = (field: string, value: any) => {
+    const setField = (field: string, value: unknown) => {
         dispatch({ type: 'SET_FIELD', payload: { field, value } });
     };
 
@@ -388,7 +388,9 @@ export function useServiceForm(onCreateServiceCallback?: () => void | null) {
         try {
             if (!currentBlueprint) return;
             await navigator.clipboard.writeText(blueprintFormat === 'yaml' ? yamlConfig : jsonConfig);
-        } catch (err) {}
+        } catch (error) {
+            console.error((error as Error).message || "An unknown error occoured while retrieving blueprints")
+        }
     };
 
     return {