fix

Author: dprince

internal/openstackassistant/funcs.go

@@ -106,9 +106,9 @@ fi
 # Combine CA bundles if MCP CA is present alongside Lightspeed CA
 if [ -f /etc/ssl/certs/mcp-ca-bundle.crt ]; then
   if [ -f /etc/ssl/certs/ca-certificates.crt ]; then
-    cp /etc/ssl/certs/ca-certificates.crt /tmp/workdir/combined-ca.crt
-    cat /etc/ssl/certs/mcp-ca-bundle.crt >> /tmp/workdir/combined-ca.crt
-    export SSL_CERT_FILE=/tmp/workdir/combined-ca.crt
+    cp /etc/ssl/certs/ca-certificates.crt /tmp/combined-ca.crt
+    cat /etc/ssl/certs/mcp-ca-bundle.crt >> /tmp/combined-ca.crt
+    export SSL_CERT_FILE=/tmp/combined-ca.crt
   else
     export SSL_CERT_FILE=/etc/ssl/certs/mcp-ca-bundle.crt
   fi
@@ -209,10 +209,6 @@ func assistantPodVolumeMounts(instance *assistantv1.OpenStackAssistant, mcpCaBun
 			MountPath: "/tmp/lightspeed-provider",
 			ReadOnly:  true,
 		},
-		{
-			Name:      "workdir",
-			MountPath: "/tmp/workdir",
-		},
 	}
 
 	if instance.Spec.Goose != nil {
@@ -274,12 +270,6 @@ func assistantPodVolumes(instance *assistantv1.OpenStackAssistant, mcpCaBundleSe
 				},
 			},
 		},
-		{
-			Name: "workdir",
-			VolumeSource: corev1.VolumeSource{
-				EmptyDir: &corev1.EmptyDirVolumeSource{},
-			},
-		},
 	}
 
 	if instance.Spec.Goose != nil {

internal/openstackassistant/funcs_test.go

@@ -147,19 +147,19 @@ func TestAssistantPodSpec_MinimalVolumes(t *testing.T) {
 
 	spec := AssistantPodSpec(instance, "hash", nil, "")
 
-	g.Expect(spec.Volumes).To(HaveLen(3))
+	g.Expect(spec.Volumes).To(HaveLen(2))
 
 	volumeNames := make([]string, len(spec.Volumes))
 	for i, v := range spec.Volumes {
 		volumeNames[i] = v.Name
 	}
-	g.Expect(volumeNames).To(ContainElements("entrypoint", "lightspeed-provider", "workdir"))
+	g.Expect(volumeNames).To(ContainElements("entrypoint", "lightspeed-provider"))
 
 	mountNames := make([]string, len(spec.Containers[0].VolumeMounts))
 	for i, m := range spec.Containers[0].VolumeMounts {
 		mountNames[i] = m.Name
 	}
-	g.Expect(mountNames).To(ContainElements("entrypoint", "lightspeed-provider", "workdir"))
+	g.Expect(mountNames).To(ContainElements("entrypoint", "lightspeed-provider"))
 }
 
 func TestAssistantPodSpec_WithRecipesAndHints(t *testing.T) {
@@ -172,12 +172,12 @@ func TestAssistantPodSpec_WithRecipesAndHints(t *testing.T) {
 
 	spec := AssistantPodSpec(instance, "hash", nil, "")
 
-	g.Expect(spec.Volumes).To(HaveLen(5))
+	g.Expect(spec.Volumes).To(HaveLen(4))
 	volumeNames := make([]string, len(spec.Volumes))
 	for i, v := range spec.Volumes {
 		volumeNames[i] = v.Name
 	}
-	g.Expect(volumeNames).To(ContainElements("entrypoint", "lightspeed-provider", "workdir", "recipes", "hints"))
+	g.Expect(volumeNames).To(ContainElements("entrypoint", "lightspeed-provider", "recipes", "hints"))
 
 	mountNames := make([]string, len(spec.Containers[0].VolumeMounts))
 	for i, m := range spec.Containers[0].VolumeMounts {
@@ -193,7 +193,7 @@ func TestAssistantPodSpec_WithCaBundle(t *testing.T) {
 
 	spec := AssistantPodSpec(instance, "hash", nil, "")
 
-	g.Expect(spec.Volumes).To(HaveLen(4))
+	g.Expect(spec.Volumes).To(HaveLen(3))
 
 	var caBundleVolume *corev1.Volume
 	for i := range spec.Volumes {
@@ -292,9 +292,6 @@ func TestAssistantPodSpec_AllVolumeMountsReadOnly(t *testing.T) {
 	spec := AssistantPodSpec(instance, "hash", nil, "")
 
 	for _, mount := range spec.Containers[0].VolumeMounts {
-		if mount.Name == "workdir" {
-			continue
-		}
 		g.Expect(mount.ReadOnly).To(BeTrue(), "VolumeMount %s should be read-only", mount.Name)
 	}
 }
@@ -308,7 +305,7 @@ func TestAssistantPodSpec_RecipesOnlyNoHints(t *testing.T) {
 
 	spec := AssistantPodSpec(instance, "hash", nil, "")
 
-	g.Expect(spec.Volumes).To(HaveLen(4))
+	g.Expect(spec.Volumes).To(HaveLen(3))
 	volumeNames := make([]string, len(spec.Volumes))
 	for i, v := range spec.Volumes {
 		volumeNames[i] = v.Name